Identify world.status.announcement_alert fields #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ab9rf
reviewed
Dec 24, 2023
ab9rf
reviewed
Dec 24, 2023
ab9rf
reviewed
Dec 24, 2023
df.announcements.xml
Outdated
| <enum base-type='int32_t' type-name='announcement_alert_type' name='type'/> | ||
| <stl-vector name='report_id' type-name='int32_t'/> | ||
| <stl-vector name='unit_id' type-name='int32_t'/> | ||
| <stl-vector name='combat_type'> |
There was a problem hiding this comment.
bay12 name is report_unit_announcement_category (and the vector type is UnitAnnouncementCategory)
There was a problem hiding this comment.
I'm using a pre-existing enum for the category. Doesn't look like original-name works with enum, so I've just put a comment on it in df.units.xml.
* Update df.announcements.xml * Update df.units.xml
ab9rf
reviewed
Dec 25, 2023
myk002
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify
announcement_alertfields based on use inmake_announcement(FUN_1400574e0v50.11 win64 Steam.) Naming the structannouncement_alertstbased on convention.Additionally defined the
alert_button_announcement_idvector asint32_t, since it usesreport.id.