Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

canonicalize unitst::emotions #721

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

ab9rf
Copy link
Member

@ab9rf ab9rf commented Feb 10, 2024

warning: this breaks misery.cpp, add-thought.lua, and export-dt-ini.lua; coordination required

mappings for updating references in the foregoing:

  • unit_personality::T_emotions -> personality_moodst
  • unit_personality::T_emotions::unk2 -> personality_moodst::strength
  • unit_personality::T_emotions::strength -> personality_moodst::relative_strength
  • unit_personality::T_emotions::unk7 -> personality_moodst::next_overcome_timer

i don't believe any of the flags added by this PR were being used as unks

also known as `unitst::mood`

warning: this breaks misery.cpp, add-thought.lua, and export-dt-ini.lua
@myk002 myk002 merged commit 7799fc5 into DFHack:master Mar 3, 2024
11 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants