Announcement_infost flag indicates sparring; identify unit_action_data_attack flag #738
Conversation
df.units.xml
Outdated
| <flag-bit name='charge' comment='(INDEPENDENT_MULTIATTACK)'/> | ||
| <flag-bit name='bad_multiattack' comment='(BAD_MULTIATTACK)'/> | ||
| <flag-bit name='zero_criticals' comment='(ZERO_CRITICALS)'/> | ||
| <flag-bit name='lightly_tap' comment='(NO_LETHAL_INTENT)'/> | ||
| <flag-bit name='automatic_hit' comment='(AUTOMATIC_HIT)'/> | ||
| <flag-bit name='sparring_hit' comment='(SPARRING_HIT)'/> | ||
| <flag-bit name='spar_report' comment='()'/> |
There was a problem hiding this comment.
Should charge be renamed independent_multiattack?
What's the Bay12 name for spar_report?
There was a problem hiding this comment.
I'd say keep charge as it is.
There does not appear to be a bit for spar_report -- the header just goes up to SPARRING_HIT. That flag bit may need to be removed
There was a problem hiding this comment.
i can't find any indication for a use of bit15 and believe we can safely remove spar_report
There was a problem hiding this comment.
I'd say keep
chargeas it is.
Does it correctly describe the behavior? I.e., is the bit set when colliding during a charge?
There was a problem hiding this comment.
We just have a general policy of "if it's named, then don't change it unless it's egregious". Behavior notes can go in the comment.
|
Coordinate with DFHack/dfhack#4247 |
|
If you've got a list of all the |
|
Do you mean #define UNIT_MOVE_MOVE_FLAG_CHARGE BIT1
#define UNIT_MOVE_MOVE_FLAG_FROM_SPARRING BIT2for |
|
actually, let's get this one merged so we can resolve the build error. Further changes can be in a separate PR |
#714
Accidentally deleted repository before merge.