automated symbol generation scripts for Linux and Windows #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
changed the title
|
merging so I can start playing with github actions that use these scripts, but please review at your leisure |
lethosor
reviewed
Apr 18, 2024
Comment on lines
+122
to
+124
| <symbol-table name='v0.00.00 win64 LOCAL' os-type='windows'> | ||
| <binary-timestamp value='0x00000000'/> | ||
| </symbol-table> |
There was a problem hiding this comment.
We already have a template starting around line 3. I'd rather keep it at that to avoid stub symbol tables like this getting read by DFHack (and potentially used, if the md5 or PE calculation fails for some reason).
We can definitely reduce the existing template to just the PE/MD5 lines though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
automates Linux symbols.xml updates