Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't publicly export structs and unions that have no names #768

Merged
merged 4 commits into from
May 28, 2024

Conversation

myk002
Copy link
Member

@myk002 myk002 commented May 27, 2024

This prevents linkage errors on Windows where multiple anonymous structs or unions are declared in the same namespace. These symbols weren't useful to export anyway (AFAICT).

@myk002 myk002 changed the title add back union structure don't publicly export structs and unions that have no names May 28, 2024
@myk002 myk002 merged commit 9c7c2fb into DFHack:adv-beta May 28, 2024
13 of 17 checks passed
@myk002 myk002 deleted the myk_union branch May 28, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant