Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo changes to material_common #773

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Undo changes to material_common #773

merged 1 commit into from
Jun 2, 2024

Conversation

quietust
Copy link
Member

@quietust quietust commented Jun 2, 2024

We really shouldn't be using "inherits-from" for copy/paste avoidance, because Windows and Linux have different rules for alignment/padding when subclasses are involved.

We really shouldn't be using "inherits-from" for copy/paste avoidance,
because Windows and Linux have different rules for alignment/padding
when subclasses are involved.
Copy link
Contributor

github-actions bot commented Jun 2, 2024

The sizes of the following types have changed in this pull request. Please verify that this is intentional. Note that renamed types are not currently detected and will also be listed here.

Type Platform Previous size New size (this PR) Change
material_common linux64 1240 1216 -24
material_common windows64 1240 1216 -24
material_template windows64 1528 1520 -8

This is an automated comment. Please leave a reply if you think that the above information is incorrect.

@quietust quietust merged commit 65592ad into DFHack:master Jun 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant