Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mechanism unlinking functionality to buildingplan plugin #4389

Merged
merged 17 commits into from
Apr 1, 2024

Conversation

Bumber64
Copy link
Contributor

@Bumber64 Bumber64 commented Mar 20, 2024

Adds ability to unlink and free mechanisms from buildings.

Replaces DFHack/scripts#1016

@myk002
Copy link
Member

myk002 commented Mar 22, 2024

This is what I see, which is a bit more unstable than I'd like:

edit: replaced video with version that shows the current screen dimensions

simplescreenrecorder-2024-03-21_23.49.13.mp4

@Bumber64
Copy link
Contributor Author

Bumber64 commented Mar 22, 2024

This is what I see, which is a bit more unstable than I'd like:

Should be fixed.

Also fixed "Free all" button disappearing when freeable mechanisms are scrolled offscreen.

@Bumber64
Copy link
Contributor Author

Bumber64 commented Mar 25, 2024

Looks like all OverlayWidgets use default_pos instead of frame t/b/l/r even if they shouldn't be reposition-able? This generates a pos value in overlay.json. If we have to change the default in the future (e.g., because UI changes,) it's going to keep using the old value in every user's json.

We probably shouldn't save/load positions for OverlayWidgets with overlay_only = true. That would mean we wouldn't respond to overlay position <overlay> either? That would stop the user from manually fixing things, though.

version can be used, per Discord.

Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks!

@myk002 myk002 merged commit d079595 into DFHack:develop Apr 1, 2024
14 checks passed
@Bumber64 Bumber64 deleted the mechanisms branch April 1, 2024 04:43
@Bumber64 Bumber64 restored the mechanisms branch April 1, 2024 04:50
@Bumber64 Bumber64 deleted the mechanisms branch April 1, 2024 04:50
@Bumber64 Bumber64 restored the mechanisms branch April 1, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants