Efficiency increase for ban-cooking and change to 'seeds' option #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop iterating through materials when the material being searched for (STRUCTURAL) is found since material IDs should be unique.
Removed the check for has_drink from funcs.seeds. Currently the 'seeds' function bans seed producing items only if the item is also brewable. This allows the possibility that seeds and replanting can be lost for cookable seed producing items that are also using for milling, spinning, etc. reactions. This maybe should be split into two functions, one for banning seeds themselves and one for banning seed producing items. Currently the documentation describes this function as only banning seeds, which may lead to some confusion.
Added ban-cooking changes to changelog
myk002
reviewed
Jul 28, 2024
changelog.txt
Outdated
| @@ -93,6 +93,8 @@ Template for new versions: | |||
| - `clear-smoke`: properly tag smoke flows for garbage collection to avoid memory leak | |||
| - `warn-stranded`: don't warn for babies carried by mothers who happen to be gathering fruit from trees | |||
| - `prioritize`: also boost priority of already-claimed jobs when boosting priority of a job type so those jobs are not interrupted | |||
| - `ban-cooking`: stop iterating through plant materials when the searched-for material is found | |||
There was a problem hiding this comment.
this one is not user-visible and doesn't need a changelog line
There was a problem hiding this comment.
Alright, I've removed that line from the changelog and updated the documentation file to clarify which items the 'seeds' option affects.
Remove line from changelog referencing a non-user facing aspect of this update.
Clarify that the 'seeds' option also bans plants and growths which produce seeds in reactions.
Droseran
changed the title
myk002
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase the efficiency of ban-cooking by breaking the iteration of the material search when it finds the material ID being looked for (specifically 'STRUCTURAL' in this case).
The 'seeds' option now bans cooking for all seed producing plants and growths instead of just items that produce seeds and are brewable. The previous method could cause replantability to be lost for plants with cookable seed producing items, affecting milling in vanilla and other industries in mods. It may be a good idea to split this into two functions in the future, since the documentation only mentions that this function bans cooking seeds and not the items that produce them. This is also the only option that affects two significantly different groups of items, which is a bit inconsistent.