Fix gui/autodump dumping into walls, etc. #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Jul 28, 2024
|
also needs a doc update defining what an acceptable target tile is |
|
Renaming branches closes PRs, apparently. |
|
Looks like we need to be setting some projectile flags. The falling items are sometimes getting destroyed regardless. |
myk002
reviewed
Jul 31, 2024
* Update autodump.lua * Update autodump.rst * Update changelog.txt
myk002
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent
gui/autodumpfrom attempting to dump into or select within unallocated tiles (e.g., below HFS), which causes a script error. Also prevent dumping into hidden tiles.Prevent dumping into walls. Set proper projectile flags so falling items don't get destroyed on impact.