-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new tool: immortal-cravings #1301
Conversation
da97995
to
a342a22
Compare
this is an awesome name : D however, I am seeing a parallel with the concept of Would it make sense to rename |
I'm not entirely sure. There obviously are parallels, but From the communication perspective, From the development perspective, every need that we satisfy using a tool requires some amount of research and discussion. And other needs may require entirely different techniques. So maybe it is good to keep this thing separate for now. Ultimately, I expect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you also add this tool to the control panel registry (internal/control-panel/registry.lua
)?
It may take until the next weekend for me to get back to this. Busy at work and other plans for the upcoming weekend. |
no hurry! I have plenty of other PRs to keep me busy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add immortal-cravings
to the control panel registry (internal/control-panel/registry.lua
)?
Also, could you add a line to the New Tools section of the changelog? edit: didn't see that you already did
allow immortals to satisfy their cravings for food and drink