Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give position.rst the "dfhack" tag #1308

Merged
merged 7 commits into from
Sep 28, 2024
Merged

Conversation

Bumber64
Copy link
Contributor

@Bumber64 Bumber64 commented Sep 21, 2024

Give position tool the dfhack tag since it can be used to copy coords for other tools. (Need to update spreadsheet doc.)

Left a note in the unavailable modtools/reaction-trigger.lua that inactive unit positions are meaningless. (Should probably ignore range for these units and have some kind of filter?) If it's meant to work on corpses, you'd need to operate on items.

Fixed a stray period in exterminate.rst.

getUnitsInBox now only returns active units
Inactive units shouldn't use range if anybody updates this tool.
getUnitsInBox now returns active by default
Stray punctuation
@myk002
Copy link
Member

myk002 commented Sep 28, 2024

you might want to move the parts that depend on DFHack/dfhack#4959 to another PR. 4959 might spark research and debate and might not get merged any time soon

* Update stuckdoors.lua
* Update deep-embark.lua
@Bumber64 Bumber64 changed the title Give position.rst the "dfhack" tag; changes relating to active units Give position.rst the "dfhack" tag Sep 28, 2024
@myk002 myk002 merged commit 630b49b into DFHack:master Sep 28, 2024
10 checks passed
@Bumber64 Bumber64 deleted the active_units branch September 28, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants