Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[control-panel] convert numeric strings to numbers for numeric preferences #1314

Merged
merged 2 commits into from
Oct 2, 2024
+4 −0
Merged

[control-panel] convert numeric strings to numbers for numeric preferences #1314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c6fa952
convert numeric strings to numbers for numeric preferences
myk002 Oct 2, 2024
1c2b1a0
use original type if not numeric
myk002 Oct 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Template for new versions:

## Fixes
- `gui/quickfort`: only print a help blueprint's text once even if the repeat setting is enabled
- `control-panel`: fix setting numeric preferences from the commandline

## Misc Improvements
- `control-panel`: Add realistic-melting tweak to control-panel registry
Expand Down
3 changes: 3 additions & 0 deletions internal/control-panel/common.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,9 @@ function set_preference(data, in_value)
if expected_type == 'boolean' and type(value) ~= 'boolean' then
value = argparse.boolean(value)
end
if expected_type == "number" then
value = tonumber(value) or value
end
local actual_type = type(value)
if actual_type ~= expected_type then
qerror(('"%s" has an unexpected value type: got: %s; expected: %s'):format(
Expand Down