-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alternative rightclick behavior overlay to gui/design
#1345
Conversation
since this "script" does nothing when run and is controllable entirely via other interfaces, I think we should attach it to an existing tool and document it with that tool. This is thematically linked with the tooltip overlay, so I'd suggest tacking this code onto Documentation can be added to |
fixrightclick
overlay scriptgui/design
'dwarfmode/Designate', | ||
'dwarfmode/Burrow/Paint', | ||
'dwarfmode/Stockpile/Paint', | ||
'dwarfmode/Zone/Paint', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ha - I need to handle this case for DimensionsOverlay too. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem - I actually wanted to do that myself but for some reason it wouldn't work even though I'm sure I made almost the exact same change. Must've been a syntax error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after you made the edit, did you run :lua require('plugins.overlay').rescan()
? changes to overlay widgets need to be reloaded at the framework level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, I can't remember if I did that after I'd added design.rightclick. But I definitely did restart my game
At your leisure, we would be honored if you could add your name to https://github.com/DFHack/dfhack/blob/develop/docs/about/Authors.rst |
This adds the overlay proposed in DFHack/dfhack#5025. Name tentative.