Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/adventurer journal #1409

Merged
merged 9 commits into from
Mar 8, 2025

Conversation

wiktor-obrebski
Copy link
Contributor

@wiktor-obrebski wiktor-obrebski commented Feb 26, 2025

Add adventure mode support for gui/journal.
The journal is stored per ID for the character the player created on the save.

It's not support bodyswap and other tools - using them u changing ur character, and new one will have new journal!

Also, add dedicated intro text for journal on adventure mode.

I do not see a way to test journal on CI in adventure mode right now.

@wiktor-obrebski wiktor-obrebski marked this pull request as ready for review February 26, 2025 17:35
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I suspect players will want the ability to pull up journals of non-current adventurers, but we need to provide a Lua API for pulling data by key pattern like we have for C++ to support that.

@myk002 myk002 merged commit ba1ae7e into DFHack:master Mar 8, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants