Skip to content

[immortal-cravings] prioritize high-value meals #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[immortal-cravings] prioritize high-value meals #1475

wants to merge 2 commits into from

Conversation

chdoc
Copy link
Member

@chdoc chdoc commented Jul 4, 2025

... and don't go eating or drinking on a full stomach

fixes: DFHack/dfhack#5401

ab9rf
ab9rf reviewed Jul 4, 2025
View reviewed changes
@chdoc
Copy link
Member Author

chdoc commented Jul 12, 2025

If there are no more required changes, can we get this merged?

@chdoc
Copy link
Member Author

chdoc commented Aug 2, 2025

Now that this has been sitting here for a while, I went ahead and made a few additional changes:

  • properly split off an individual portion when assigning an eat job to a unit
  • actually made findClosest an instance of findBest, simplifying the interface of the latter to only take a single function

@chdoc chdoc requested a review from ab9rf August 2, 2025 20:24
ab9rf
ab9rf approved these changes Aug 6, 2025
View reviewed changes
Copy link
Member

@ab9rf ab9rf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ab9rf ab9rf ab9rf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change immortal-cravings to prefer high-value meals
2 participants
@chdoc @ab9rf