Update exterminate script and documentation #1489
Open
+9
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
|
needs changelog |
Thanks I’ll do this in about eight hours once I get out of work. |
|
I do not know exactly how to successfully add a changelog.txt so I'm going to add it here in the description of what I believe needs to bee added in this changelog.txt. exterminate: now accepts a "-c" argument which targets only children. Case sensitive. |
ab9rf
reviewed
Aug 15, 2025
| }, {...} | ||
|
|
||
| local positionals = argparse.processArgsGetopt(args, { | ||
| {'h', 'help', handler = function() options.help = true end}, | ||
| {'m', 'method', handler = function(arg) options.method = killMethod[arg:upper()] end, hasArg = true}, | ||
| {'o', 'only-visible', handler = function() options.only_visible = true end}, | ||
| {'f', 'include-friendly', handler = function() options.include_friendly = true end}, | ||
| {'c', 'children-only', handler = function() options.children_only = true end}, |
There was a problem hiding this comment.
I would prefer that if you're going to add "children-only" you should also add "adult-only" just for parallelism
also, this won't kill babies. is this intended? should it kill babies? if not, should it offer a "baby-only" option?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please update exterminate to add a -c flag that targets only child units. I plan to build a timer-based script to run this so poults don’t wander off and put dwarven children at risk.
Argument parsing: adds -c alongside existing flags.
-c purpose: target children only.
Example:
exterminate -f -c bird_turkey -m knockout
[edit Aug/09/2025]
I do not know exactly how to successfully add a changelog.txt so I'm going to add it here in the description of what I believe needs to bee added in this changelog.txt.