Allow raw fish option to be set from command line #829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myk002
reviewed
Sep 9, 2023
docs/autofish.rst
Outdated
| ``-r``, ``--toggle-raw`` | ||
| (default: on) to toggle letting the script also count your raw fish as part | ||
| of your quota. Use it a second time to disable this. | ||
| ``r``, ``--raw <true | false>`` |
There was a problem hiding this comment.
the example -r commandline below should be updated too
autofish.lua
Outdated
| set_useRaw(toBool[optArg]) | ||
| else | ||
| qerror("Invalid argument to --raw \"".. optArg .."\". expected boolean") | ||
| return |
There was a problem hiding this comment.
no need for return -- qerror throws
Missed optional argument [] Co-authored-by: Myk <[email protected]>
fix text formatting of command output Co-authored-by: Myk <[email protected]>
fix wording of command description Co-authored-by: Myk <[email protected]>
myk002
approved these changes
Sep 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes changes necessary to replace the "count raw fish" switch on the command line into a settable option, instead of a toggle.
Other minor changes to output as well.