-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
persist liquidSources table #920
Conversation
persisting but sources will stack instead of overwrite if one is added to a tile that already has one. i imagine we don't want more than once source on a tile so i can add that in, but persistence is currently functional 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like all the major pieces are in place! great job! just needs some cleanup. Thank you for getting this done! I can do another review pass once this is cleaned up.
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
o.O I thought I'd be triggering a cleanup of the trailing whitespace that the precommit check was showing failed, I didn't intend for a build to be triggered. Apologies for any mess that caused 😬 |
A build is supposed to be triggered after every change -- that's how we detect potential failures before we merge them. Not a mess. Working as intended. |
Should be ready for 👀 again! The rearrangement of functions and some cleanup means some of the comments aren't resolving, but I think I got everything that was active |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good! remember to add a line to the Misc Improvements section (under the "Future" version header) of changelog.txt. Something like:
- `source`: now saves its state with the fort
Great job with this! Thank you for working with me through all the comments! |
Fixes DFHack/dfhack#4131