[devel/scan-vtables] pick up unique vtable addresses only in g_src #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lethosor
reviewed
Feb 3, 2024
| if (not range.read) or range.write or range.execute then | ||
| goto next_range | ||
| end | ||
| if not not range.name:match('g_src') ~= g_src then |
There was a problem hiding this comment.
I think we could just add g_src to the allowed patterns, instead of refactoring the whole loop into a function and calling it twice. Unless I'm missing something, it doesn't look like the g_src parameter is used for anything except determining the allowed ranges.
There was a problem hiding this comment.
the two passes is to ensure that if there is a dup, the version in dwarfort is preferred. Note the new names set that detects duplicates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since there are some symbols that are not in
dwarfort:<vtable-address name='enablerst' value='0x7ffff6ce6008'/><vtable-address name='renderer_2d_base' value='0x7ffff6ce6020'/><vtable-address name='renderer_2d' value='0x7ffff6ce6108'/><vtable-address name='enabler_inputst' value='0x7ffff6ce6200'/><vtable-address name='MacroScreenLoad' value='0x7ffff6ce64e0'/><vtable-address name='MacroScreenSave' value='0x7ffff6ce6548'/><vtable-address name='renderer_offscreen' value='0x7ffff6ce65c8'/><vtable-address name='widgets::folder' value='0x7ffff6ce6bc0'/><vtable-address name='widgets::filter' value='0x7ffff6ce6c20'/><vtable-address name='widgets::multifilter::indiv_filter' value='0x7ffff6ce6c88'/><vtable-address name='widgets::multifilter' value='0x7ffff6ce6cf0'/><vtable-address name='widgets::radio_rows' value='0x7ffff6ce6f80'/><vtable-address name='widgets::table' value='0x7ffff6ce6fe0'/><vtable-address name='widgets::better_button' value='0x7ffff6ce70c0'/><vtable-address name='widgets::character' value='0x7ffff6ce72a0'/><vtable-address name='widgets::dropdown' value='0x7ffff6ce75d0'/>