Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modtools/reaction-trigger] don't enable events until we need them #975

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

myk002
Copy link
Member

@myk002 myk002 commented Feb 13, 2024

this is not a full implementation since the event will stay enabled at frequency 0 even if the reactions are cleared, but at least this will prevent the event from being enabled for users that don't even use the script (which is the majority)

@myk002 myk002 merged commit e7637a9 into DFHack:master Feb 13, 2024
10 checks passed
@myk002 myk002 deleted the myk_reactiontrigger branch February 13, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant