Add names to the list of authors #142
Conversation
realSquidCoder
changed the title
Contributions.txt
Outdated
| @@ -1 +1 @@ | |||
| 7� Nickel, BatCountry, Belal, Belannaer, Caldfir, DeKaFu, Dante, Deon, dyze, Errol, fifth angel, frumpton, IDreamOfGiniCoeff, Impaler, Japa, jarathor, Jiri Petru, Jordix, Lord Nightmare, McMe, Mike Mayday, Nexii Malthus, peterix, Seuss, soup, Talvara, winner, Xandrin, | |||
| 7� Nickel, BatCountry, Belal, Belannaer, Caldfir, DeKaFu, Dante, Deon, dyze, Errol, fifth angel, frumpton, IDreamOfGiniCoeff, Impaler, Japa, jarathor, Jiri Petru, Jordix, Lord Nightmare, McMe, Mike Mayday, Nexii Malthus, peterix, Seuss, soup, SquidCoder, Talvara, winner, Xandrin, | |||
There was a problem hiding this comment.
do you know what that character is supposed to be for 7c Nickel? It is displayed in the UI as a c, both before and after this change, but in reality, this PR changes the character in the file:
that is, it's being changed from cp437 character 0xA2 to what looks like a unicode character. I'd look into the expected encoding of this file to make sure this is a correct change.
There was a problem hiding this comment.
i think its a "cent" sign?
There was a problem hiding this comment.
what encoding does it need to be in for display?
There was a problem hiding this comment.
idk but i can tell you its a cent sign by looking at the df wiki:
There was a problem hiding this comment.
My question is: what encoding does the allegro function that renders the text expect? Let's use that encoding.
There was a problem hiding this comment.
oh, n/m this file isn't read, is it? This should be UTF-8, then, and my question applies to line 199 in main.cpp
There was a problem hiding this comment.
i think, there, its literally just the letter c
There was a problem hiding this comment.
yeah, but that's incorrect, isn't it? it should be the cent sign
There was a problem hiding this comment.
its been the c for as long as i know
| @@ -199,9 +199,9 @@ void drawcredits() | |||
| al_draw_text(font, color_white, centerx, bottomy-12*lineheight, ALLEGRO_ALIGN_CENTRE, "7c Nickel, BatCountry, Belal, Belannaer, DeKaFu, Dante, Deon, dyze,"); | |||
There was a problem hiding this comment.
| al_draw_text(font, color_white, centerx, bottomy-12*lineheight, ALLEGRO_ALIGN_CENTRE, "7c Nickel, BatCountry, Belal, Belannaer, DeKaFu, Dante, Deon, dyze,"); | |
| al_draw_text(font, color_white, centerx, bottomy-12*lineheight, ALLEGRO_ALIGN_CENTRE, "7¢ Nickel, BatCountry, Belal, Belannaer, DeKaFu, Dante, Deon, dyze,"); |
There was a problem hiding this comment.
From the allegro docs:
Some parts of the Allegro API, such as the font rountines[sic], expect Unicode strings encoded in UTF-8.
There was a problem hiding this comment.
MSVC will (most likely) encode that string in CP-1252, not UTF-8; ¢ has an encoding in CP-1252, but that encoding will yield a byte sequence that won't decode to ¢ as UTF-8.
You need to use a u8 encoding override if you want to guarantee the compiler encodes that as a UTF-8 string.
I also can't guarantee that al_draw_text will properly handle UTF-8. There is an al_draw_ustr which takes an ALLEGRO_USTR object as its parameter. ALLEGRO_USTR is allegro's type for representing UTF-8 strings.
There was a problem hiding this comment.
i'd rather leave it as "c" if we're unsure that it'll work
Co-authored-by: Myk <[email protected]>
@ab9rf Please add your name too if you wish it to be included, you deserve this as much as I, if not more so. :)