Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mimic the df::coord isValid() check #210

Closed
wants to merge 1 commit into from
Closed

Mimic the df::coord isValid() check #210

wants to merge 1 commit into from

Conversation

realSquidCoder
Copy link
Collaborator

This should be a simple PR to merge rly quick

myk002
myk002 reviewed Feb 21, 2025
View reviewed changes
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing a space between >= and 0 (for formatting consistency)

plz fix merge conflicts; otherwise LGTM

@realSquidCoder
Copy link
Collaborator Author

missing a space between >= and 0 (for formatting consistency)

plz fix merge conflicts; otherwise LGTM

actually we can close without merge. the conflicts are what supersedes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myk002 myk002 myk002 left review comments

Assignees
No one assigned
Labels
None yet
Projects
51.05-r2
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realSquidCoder @myk002