-
-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake V2 + Cpp20 + (Almost) Header only #1757
Conversation
Fixing BasicTypes with std uint32_t instead of boost::uint32_t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edits
Before I can merge, can you please enhanced a bit the changelog? |
|
I enhanced a bit the changelog, is it sufficient ? I made minor edits to moduleBuildDGtal.dox. But I do not know if anything more is needed... Everything is backward compatible; cmake commands, variable as well as C++ modules are the same.
|
Btw : Shall I also clean the Codacy Static Code analysis? |
Note: do not merge yet, there is no test / examples built by the PR. Wait a bit until I fixed DGTalTools / DGTal compilation with the new build system. |
Hey @dcoeurjo I fixed the compilation with DGTalTools. Can you check that the new GH action suits you ? It checks compilation against the PR main2.0 of DGTalTools. The last commits also changes the Install.cmake and the CheckDependancies files (there was an issue with ITK including non-existent paths...). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good thx!
I will merge this one to the main2.0 branch, thx @BDoignies |
all good, merging, thx |
PR Description
A proposal for new CMake :
Header only changes:
Standard to C++20, which has the following side effects on the code:
TODO :
Sorry for the big PR, there was a bit too much cascading from what I thought were simple changes...
Checklist