Cpp20 concepts kernel #1761
Open
Cpp20 concepts kernel #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As they were a simple refinement, BOOST_CONCEPT_CHECK and inheritance were invalid. This includes: - CUnaryFunctor - CPredicate - CPointFunctor - CPointPredicate - CSurfelPredicate
DGTAL_CONCEPT_CHECK macro does not work with clang inside template function. It considers that the lambda call is not a constant expression and therfore does not allows to instantiate the variable.
Note: testEstimatorComparator does not compile.
For unknown reasons, this compiler version crashes with error C1001: Internal compiler error. This patch was found by trial and error and works but I do not know why it fixes things (on my computer at least). If I were to guess (with the fixes in mind), it is due to some kind of name-dependant lookup that it can not handles or find in some compilation context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Cpp20 concepts for kernel/ package. Note: this PR is not complete yet, but as CInteger is a huge concept, it is filed now to check against github actions.
Checklist