Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwitcherLoader nic #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

SwitcherLoader nic #4

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Feb 4, 2012

Would you be kind enough to add this with the other templates??

@DHowett
Copy link
Owner

DHowett commented Feb 4, 2012

Complaints:

  • Inconsistent indenting in Info.plist
  • No indentation in the source file
  • for the love of god please do NOT create your view hierarchy in layoutSubviews it's for laying out existing subviews
  • Give the main implementation file a header, and include that.
  • The section: should be Addons (SwitcherLoader), NOT Tweaks. It is not a tweak.
  • Where else do you see objective-c classes with underscores in their names? Maybe @@PROJECTNAME@@View instead of @@PROJECTNAME@@_view would be better.
  • (architecture issue) Why not use CFBundleIconFile instead of icon? Info.plist and bundles already have provisions for including Icons.

@DHowett
Copy link
Owner

DHowett commented Feb 4, 2012

One more:

  • The filename does not match the class inside it.

@DHowett
Copy link
Owner

DHowett commented Feb 4, 2012

Another architecture issue:

  • Why not use CFBundleDisplayName instead of name? Info.plist and bundles already have provisions for including user-facing names.

@ghost
Copy link
Author

ghost commented Feb 4, 2012

Sorry, submitted older version :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant