[#429] Send correct `<option>` value for StartupPack #430

korydraughn · 2023-11-21T20:28:48Z

This is required for proper communication over TLS/SSL.

Will run the test suite soon.

korydraughn · 2023-11-28T20:21:10Z

The following test failures were encountered with this change. It's not clear to me whether these were caused by the change. This was tested using the docker compose setup defined in the docker-test-framework/latest directory of the project.

[ERROR] Tests run: 1558, Failures: 1, Errors: 14, Skipped: 0, Time elapsed: 1,531.935 s <<< FAILURE! - in org.irods.jargon.core.unittest.AllTests                       
[ERROR] testAddDuplicateResource(org.irods.jargon.core.pub.ResourceAOTest)  Time elapsed: 0.276 s  <<< ERROR!                                                           
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<org.irods.jargon.core.exception.CatalogSQLException>
        at org.irods.jargon.core.pub.ResourceAOTest.testAddDuplicateResource(ResourceAOTest.java:516)                                                                   
                                                                                               
[ERROR] testAddUserMetadataTwice(org.irods.jargon.core.pub.UserAOTest)  Time elapsed: 0.025 s  <<< ERROR!                                                               
org.irods.jargon.core.exception.CatalogSQLException: Catalog SQL error                         
        at org.irods.jargon.core.pub.UserAOTest.testAddUserMetadataTwice(UserAOTest.java:1039) 
                                                                                               
[ERROR] testAddDuplicateUser(org.irods.jargon.core.pub.UserAOTest)  Time elapsed: 0.052 s  <<< ERROR!                                                                   
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<org.irods.jargon.core.exception.CatalogSQLException>
        at org.irods.jargon.core.pub.UserAOTest.testAddDuplicateUser(UserAOTest.java:769)                                                                               
                                                                                                                                                                        
[ERROR] testAddUserToGroupTwice(org.irods.jargon.core.pub.UserGroupAOImplTest)  Time elapsed: 0.026 s  <<< ERROR! 
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<org.irods.jargon.core.exception.CatalogSQLException>
        at org.irods.jargon.core.pub.UserGroupAOImplTest.testAddUserToGroupTwice(UserGroupAOImplTest.java:420)                                        
                                                                                                                                                                        
[ERROR] testAddDuplicateUserGroup(org.irods.jargon.core.pub.UserGroupAOImplTest)  Time elapsed: 0.059 s  <<< ERROR!                                         
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<org.irods.jargon.core.exception.CatalogSQLException>
        at org.irods.jargon.core.pub.UserGroupAOImplTest.testAddDuplicateUserGroup(UserGroupAOImplTest.java:598)                                             
                                                                                                                                                                        
[ERROR] testGetPermissionsForCollection(org.irods.jargon.core.pub.CollectionAOImplTest)  Time elapsed: 0.31 s  <<< FAILURE!                                             
java.lang.AssertionError: should have read permissions expected:<READ> but was:<NONE>                                                                                   
        at org.irods.jargon.core.pub.CollectionAOImplTest.testGetPermissionsForCollection(CollectionAOImplTest.java:2056)                                
                                                                                               
[ERROR] testBulkAddAvuMetadataWithDuplicate(org.irods.jargon.core.pub.CollectionAOImplTest)  Time elapsed: 0.041 s  <<< ERROR!                                          
org.irods.jargon.core.exception.CatalogSQLException: Catalog SQL error                                                                                                  
        at org.irods.jargon.core.pub.CollectionAOImplTest.testBulkAddAvuMetadataWithDuplicate(CollectionAOImplTest.java:696)                                            
                                                                                                                                                                        
[ERROR] testAddDuplicateAvuMetadataWithUnits(org.irods.jargon.core.pub.CollectionAOImplTest)  Time elapsed: 0.042 s  <<< ERROR!                                         
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<org.irods.jargon.core.exception.CatalogSQLException>
        at org.irods.jargon.core.pub.CollectionAOImplTest.testAddDuplicateAvuMetadataWithUnits(CollectionAOImplTest.java:863)                                         
                                                                                                                                                                        
[ERROR] testAddDuplicateAvuMetadata(org.irods.jargon.core.pub.CollectionAOImplTest)  Time elapsed: 0.056 s  <<< ERROR! 
org.irods.jargon.core.exception.CatalogSQLException: Catalog SQL error                                                                                                  
        at org.irods.jargon.core.pub.CollectionAOImplTest.testAddDuplicateAvuMetadata(CollectionAOImplTest.java:834)                                     
                                                                                                                                                                        
[ERROR] testAddAVUMetadataToDataObjectTwice(org.irods.jargon.core.pub.DataObjectAOImplTest)  Time elapsed: 0.193 s  <<< ERROR!
org.irods.jargon.core.exception.CatalogSQLException: Catalog SQL error
        at org.irods.jargon.core.pub.DataObjectAOImplTest.testAddAVUMetadataToDataObjectTwice(DataObjectAOImplTest.java:2832)

[ERROR] testAddAVUMetadataToDataObjectTwiceIncludeUnitsVal(org.irods.jargon.core.pub.DataObjectAOImplTest)  Time elapsed: 0.218 s  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<org.irods.jargon.core.exception.CatalogSQLException>
        at org.irods.jargon.core.pub.DataObjectAOImplTest.testAddAVUMetadataToDataObjectTwiceIncludeUnitsVal(DataObjectAOImplTest.java:2874)

[ERROR] testSetGlobalForUserThenListAllGlobalQuota(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.115 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetGlobalForUserThenListAllGlobalQuota(QuotaAOImplTest.java:152)

[ERROR] testSetUserResourceQuotaThenListUser(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.007 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetUserResourceQuotaThenListUser(QuotaAOImplTest.java:104)

[ERROR] testSetThenListGlobalQuotaForUser(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.008 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetThenListGlobalQuotaForUser(QuotaAOImplTest.java:133)

[ERROR] testSetUserResourceQuotaThenListAll(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.008 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetUserResourceQuotaThenListAll(QuotaAOImplTest.java:67)

korydraughn · 2023-11-28T20:57:16Z

Preparing to test against docker-test-framework/4-2 to see if the same failures occur.

korydraughn · 2023-11-28T21:54:23Z

All tests passed against docker-test-framework/4-2. This means the errors are specific to iRODS 4.3.

trel · 2023-11-28T22:08:08Z

Ah, interesting.

korydraughn · 2023-11-28T23:15:36Z

This may mean we need a separate branch for 4.3 or we need to make the tests operate differently based on the iRODS version.

korydraughn · 2023-11-29T20:36:09Z

Made a few more changes.

Running tests again against docker-test-framework/latest.

korydraughn · 2023-11-30T18:27:14Z

Learned that the final two test failures are due to Jargon not supporting the expanded permission levels in 4.3.

If all tests pass, I'll run the test suite against 4.2 to make sure everything is still good.

korydraughn · 2023-11-30T19:00:16Z

All tests passed for docker-test-framework/latest. Some tests were updated to be skipped.

Running against docker-test-framework/4-2 now.

If all tests pass, I'll do a final pass over the changes to make sure everything is handled correctly.

korydraughn · 2023-11-30T19:59:30Z

All tests passed for docker-test-framework/4-2.

Will double check the code changes before merging.

jargon-core/src/main/java/org/irods/jargon/core/connection/IRODSServerProperties.java

jargon-core/src/test/java/org/irods/jargon/core/pub/DataObjectAOImplTest.java

jargon-core/src/test/java/org/irods/jargon/core/pub/CollectionAOImplTest.java

jargon-core/src/test/java/org/irods/jargon/core/pub/QuotaAOImplTest.java

jargon-core/src/test/java/org/irods/jargon/core/pub/UserAOTest.java

jargon-core/src/test/java/org/irods/jargon/core/pub/CollectionAOImplTest.java

korydraughn · 2023-12-01T14:35:00Z

To determine whether the server version detection function is correct, I did the following:

Configured the test harness to install iRODS 4.3.0
Included only the fix for the StartupPack class

Here are the test results ...

[ERROR] Tests run: 1558, Failures: 3, Errors: 10, Skipped: 0, Time elapsed: 1,625.472 s <<< FAILURE! - in org.irods.jargon.core.unittest.AllTests                             
[ERROR] testAddDuplicateResource(org.irods.jargon.core.pub.ResourceAOTest)  Time elapsed: 0.204 s  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<org.irods.jargon.core.exception.CatalogSQLException>
        at org.irods.jargon.core.pub.ResourceAOTest.testAddDuplicateResource(ResourceAOTest.java:516)
                                                                                               
[ERROR] testAddDuplicateUser(org.irods.jargon.core.pub.UserAOTest)  Time elapsed: 0.051 s  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<org.irods.jargon.core.exception.CatalogSQLException>
        at org.irods.jargon.core.pub.UserAOTest.testAddDuplicateUser(UserAOTest.java:769)
                                                                                               
[ERROR] testAddUserToGroupTwice(org.irods.jargon.core.pub.UserGroupAOImplTest)  Time elapsed: 0.027 s  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<org.irods.jargon.core.exception.CatalogSQLException>
        at org.irods.jargon.core.pub.UserGroupAOImplTest.testAddUserToGroupTwice(UserGroupAOImplTest.java:420)
                                                                                               
[ERROR] testAddDuplicateUserGroup(org.irods.jargon.core.pub.UserGroupAOImplTest)  Time elapsed: 0.082 s  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<org.irods.jargon.core.exception.CatalogSQLException>
        at org.irods.jargon.core.pub.UserGroupAOImplTest.testAddDuplicateUserGroup(UserGroupAOImplTest.java:598)                                         
                                                                                               
[ERROR] testGetPermissionsForCollection(org.irods.jargon.core.pub.CollectionAOImplTest)  Time elapsed: 0.278 s  <<< FAILURE!
java.lang.AssertionError: should have read permissions expected:<READ> but was:<NONE>                                                                                         
        at org.irods.jargon.core.pub.CollectionAOImplTest.testGetPermissionsForCollection(CollectionAOImplTest.java:2056)
                                                                                               
[ERROR] testBulkAddAvuMetadataWithDuplicate(org.irods.jargon.core.pub.CollectionAOImplTest)  Time elapsed: 0.044 s  <<< FAILURE!
java.lang.AssertionError: did not get the duplicate message expected:<DUPLICATE_AVU> but was:<OK>
        at org.irods.jargon.core.pub.CollectionAOImplTest.testBulkAddAvuMetadataWithDuplicate(CollectionAOImplTest.java:716)
                                                                                                                                                                              
[ERROR] testAddDuplicateAvuMetadataWithUnits(org.irods.jargon.core.pub.CollectionAOImplTest)  Time elapsed: 0.027 s  <<< FAILURE!
java.lang.AssertionError: Expected exception: org.irods.jargon.core.exception.DuplicateDataException
                                                                                               
[ERROR] testAddAVUMetadataToDataObjectTwiceIncludeUnitsVal(org.irods.jargon.core.pub.DataObjectAOImplTest)  Time elapsed: 0.262 s  <<< ERROR!
java.lang.Exception: Unexpected exception, expected<org.irods.jargon.core.exception.DuplicateDataException> but was<java.lang.AssertionError>
        at org.irods.jargon.core.pub.DataObjectAOImplTest.testAddAVUMetadataToDataObjectTwiceIncludeUnitsVal(DataObjectAOImplTest.java:2881)

[ERROR] testExtractBundleWithOverwriteNoBulkWhenTargetCollectionAlreadyExists(org.irods.jargon.core.pub.BulkFileOperationsAOImplTest)  Time elapsed: 3.719 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-77000
        at org.irods.jargon.core.pub.BulkFileOperationsAOImplTest.testExtractBundleWithOverwriteNoBulkWhenTargetCollectionAlreadyExists(BulkFileOperationsAOImplTest.java:511)

[ERROR] testSetGlobalForUserThenListAllGlobalQuota(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.07 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetGlobalForUserThenListAllGlobalQuota(QuotaAOImplTest.java:152)

[ERROR] testSetUserResourceQuotaThenListUser(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.009 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetUserResourceQuotaThenListUser(QuotaAOImplTest.java:104)

[ERROR] testSetThenListGlobalQuotaForUser(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.008 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetThenListGlobalQuotaForUser(QuotaAOImplTest.java:133)

[ERROR] testSetUserResourceQuotaThenListAll(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.007 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetUserResourceQuotaThenListAll(QuotaAOImplTest.java:67)

[INFO]                                                                                         
[INFO] Results:                                                                                
[INFO]                                                                                         
[ERROR] Failures:                                                                              
[ERROR]   CollectionAOImplTest.testAddDuplicateAvuMetadataWithUnits Expected exception: org.irods.jargon.core.exception.DuplicateDataException
[ERROR]   CollectionAOImplTest.testBulkAddAvuMetadataWithDuplicate:716 did not get the duplicate message expected:<DUPLICATE_AVU> but was:<OK>
[ERROR]   CollectionAOImplTest.testGetPermissionsForCollection:2056 should have read permissions expected:<READ> but was:<NONE>
[ERROR] Errors:                                                                                
[ERROR]   BulkFileOperationsAOImplTest.testExtractBundleWithOverwriteNoBulkWhenTargetCollectionAlreadyExists:511 » Jargon
[ERROR]   DataObjectAOImplTest.testAddAVUMetadataToDataObjectTwiceIncludeUnitsVal »  Une...
[ERROR]   QuotaAOImplTest.testSetGlobalForUserThenListAllGlobalQuota:152 » Jargon Unknow...
[ERROR]   QuotaAOImplTest.testSetThenListGlobalQuotaForUser:133 » Jargon Unknown iRODS e...
[ERROR]   QuotaAOImplTest.testSetUserResourceQuotaThenListAll:67 » Jargon Unknown iRODS ...
[ERROR]   QuotaAOImplTest.testSetUserResourceQuotaThenListUser:104 » Jargon Unknown iROD...
[ERROR]   ResourceAOTest.testAddDuplicateResource »  Unexpected exception, expected<org....
[ERROR]   UserAOTest.testAddDuplicateUser »  Unexpected exception, expected<org.irods.ja...
[ERROR]   UserGroupAOImplTest.testAddDuplicateUserGroup »  Unexpected exception, expecte...
[ERROR]   UserGroupAOImplTest.testAddUserToGroupTwice »  Unexpected exception, expected<...
[INFO]                                                                                         
[ERROR] Tests run: 1558, Failures: 3, Errors: 10, Skipped: 0
[INFO]                                                                                         
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Jargon 4.3.3.0-RELEASE:
[INFO]                                                                                         
[INFO] Jargon ............................................. SUCCESS [  1.165 s]
[INFO] Jargon Core ........................................ FAILURE [28:49 min]
[INFO] Jargon User Tagging ................................ SKIPPED

I'm now going to include all changes to the tests and see if they pass against iRODS 4.3.0. If they pass, then the server version detection function is fine as is.

korydraughn · 2023-12-01T15:29:56Z

And here are the results.

[ERROR] Tests run: 1553, Failures: 4, Errors: 1, Skipped: 4, Time elapsed: 1,720.194 s <<< FAILURE! - in org.irods.jargon.core.unittest.AllTests
[ERROR] testAddUserMetadataTwice(org.irods.jargon.core.pub.UserAOTest)  Time elapsed: 0.015 s  <<< FAILURE!
java.lang.AssertionError: expected org.irods.jargon.core.exception.CatalogSQLException to be thrown, but nothing was thrown
        at org.irods.jargon.core.pub.UserAOTest.testAddUserMetadataTwice(UserAOTest.java:1047)

[ERROR] testBulkAddAvuMetadataWithDuplicate(org.irods.jargon.core.pub.CollectionAOImplTest)  Time elapsed: 0.028 s  <<< FAILURE!
java.lang.AssertionError: expected org.irods.jargon.core.exception.CatalogSQLException to be thrown, but nothing was thrown
        at org.irods.jargon.core.pub.CollectionAOImplTest.testBulkAddAvuMetadataWithDuplicate(CollectionAOImplTest.java:697)

[ERROR] testAddDuplicateAvuMetadata(org.irods.jargon.core.pub.CollectionAOImplTest)  Time elapsed: 0.027 s  <<< FAILURE!
java.lang.AssertionError: expected org.irods.jargon.core.exception.CatalogSQLException to be thrown, but nothing was thrown
        at org.irods.jargon.core.pub.CollectionAOImplTest.testAddDuplicateAvuMetadata(CollectionAOImplTest.java:840)

[ERROR] testAddAVUMetadataToDataObjectTwice(org.irods.jargon.core.pub.DataObjectAOImplTest)  Time elapsed: 0.168 s  <<< FAILURE!
java.lang.AssertionError: expected org.irods.jargon.core.exception.CatalogSQLException to be thrown, but nothing was thrown
        at org.irods.jargon.core.pub.DataObjectAOImplTest.testAddAVUMetadataToDataObjectTwice(DataObjectAOImplTest.java:2834)

[ERROR] testExtractBundleWithOverwriteNoBulkWhenTargetCollectionAlreadyExists(org.irods.jargon.core.pub.BulkFileOperationsAOImplTest)  Time elapsed: 5.583 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: java.io.IOException: read length is set to zero
        at org.irods.jargon.core.pub.BulkFileOperationsAOImplTest.testExtractBundleWithOverwriteNoBulkWhenTargetCollectionAlreadyExists(BulkFileOperationsAOImplTest.java:511)
Caused by: java.io.IOException: read length is set to zero
        at org.irods.jargon.core.pub.BulkFileOperationsAOImplTest.testExtractBundleWithOverwriteNoBulkWhenTargetCollectionAlreadyExists(BulkFileOperationsAOImplTest.java:511)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Failures: 
[ERROR]   CollectionAOImplTest.testAddDuplicateAvuMetadata:840 expected org.irods.jargon.core.exception.CatalogSQLException to be thrown, but nothing was thrown
[ERROR]   CollectionAOImplTest.testBulkAddAvuMetadataWithDuplicate:697 expected org.irods.jargon.core.exception.CatalogSQLException to be thrown, but nothing was thrown
[ERROR]   DataObjectAOImplTest.testAddAVUMetadataToDataObjectTwice:2834 expected org.irods.jargon.core.exception.CatalogSQLException to be thrown, but nothing was thrown
[ERROR]   UserAOTest.testAddUserMetadataTwice:1047 expected org.irods.jargon.core.exception.CatalogSQLException to be thrown, but nothing was thrown
[ERROR] Errors: 
[ERROR]   BulkFileOperationsAOImplTest.testExtractBundleWithOverwriteNoBulkWhenTargetCollectionAlreadyExists:511 » Jargon
[INFO] 
[ERROR] Tests run: 1553, Failures: 4, Errors: 1, Skipped: 4
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Jargon 4.3.3.0-RELEASE:
[INFO] 
[INFO] Jargon ............................................. SUCCESS [  0.927 s]
[INFO] Jargon Core ........................................ FAILURE [30:18 min]
[INFO] Jargon User Tagging ................................ SKIPPED

These results represent the difference between 4.3.0 and 4.3.1. We'll have to add another server version detection method for 4.3.1.

korydraughn · 2023-12-01T22:04:08Z

Latest run against 4.3.0.

[ERROR] Tests run: 1553, Failures: 0, Errors: 1, Skipped: 7, Time elapsed: 1,668.108 s <<< FAILURE! - in org.irods.jargon.core.unittest.AllTests
[ERROR] testExtractBundleWithOverwriteNoBulkWhenTargetCollectionAlreadyExists(org.irods.jargon.core.pub.BulkFileOperationsAOImplTest)  Time elapsed: 3.125 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-77000
        at org.irods.jargon.core.pub.BulkFileOperationsAOImplTest.testExtractBundleWithOverwriteNoBulkWhenTargetCollectionAlreadyExists(BulkFileOperationsAOImplTest.java:511)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   BulkFileOperationsAOImplTest.testExtractBundleWithOverwriteNoBulkWhenTargetCollectionAlreadyExists:511 » Jargon
[INFO] 
[ERROR] Tests run: 1553, Failures: 0, Errors: 1, Skipped: 7
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Jargon 4.3.3.0-RELEASE:
[INFO] 
[INFO] Jargon ............................................. SUCCESS [  0.999 s]
[INFO] Jargon Core ........................................ FAILURE [29:27 min]
[INFO] Jargon User Tagging ................................ SKIPPED

Once I work this out, I'll run against 4.2.12 and 4.3.1.

korydraughn · 2023-12-02T18:45:21Z

Test results against 4.3.1. The quota tests assumptions need to be changed so that the failing tests only run when the iRODS version is pre 4.3.0.

[ERROR] Tests run: 1553, Failures: 0, Errors: 4, Skipped: 0, Time elapsed: 1,472.754 s <<< FAILURE! - in org.irods.jargon.core.unittest.AllTests
[ERROR] testSetGlobalForUserThenListAllGlobalQuota(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.125 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetGlobalForUserThenListAllGlobalQuota(QuotaAOImplTest.java:191)

[ERROR] testSetUserResourceQuotaThenListUser(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.009 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetUserResourceQuotaThenListUser(QuotaAOImplTest.java:134)

[ERROR] testSetThenListGlobalQuotaForUser(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.009 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetThenListGlobalQuotaForUser(QuotaAOImplTest.java:168)

[ERROR] testSetUserResourceQuotaThenListAll(org.irods.jargon.core.pub.QuotaAOImplTest)  Time elapsed: 0.01 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-169000
        at org.irods.jargon.core.pub.QuotaAOImplTest.testSetUserResourceQuotaThenListAll(QuotaAOImplTest.java:74)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   QuotaAOImplTest.testSetGlobalForUserThenListAllGlobalQuota:191 » Jargon Unknow...
[ERROR]   QuotaAOImplTest.testSetThenListGlobalQuotaForUser:168 » Jargon Unknown iRODS e...
[ERROR]   QuotaAOImplTest.testSetUserResourceQuotaThenListAll:74 » Jargon Unknown iRODS ...
[ERROR]   QuotaAOImplTest.testSetUserResourceQuotaThenListUser:134 » Jargon Unknown iROD...
[INFO] 
[ERROR] Tests run: 1553, Failures: 0, Errors: 4, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Jargon 4.3.3.0-RELEASE:
[INFO] 
[INFO] Jargon ............................................. SUCCESS [  1.177 s]
[INFO] Jargon Core ........................................ FAILURE [26:29 min]
[INFO] Jargon User Tagging ................................ SKIPPED

korydraughn · 2023-12-02T18:58:31Z

The failing test captured here, #430 (comment), just needs to skipped when testing against 4.3.0 because iRODS 4.3.0 has already shipped.

The issue exists in 4.3.1, then we'll fix it for 4.3.2.

korydraughn · 2023-12-02T19:47:07Z

All tests passed against 4.3.1 with this PR.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Jargon 4.3.3.0-RELEASE:                             
[INFO]                                                                         
[INFO] Jargon ............................................. SUCCESS [  0.873 s]
[INFO] Jargon Core ........................................ SUCCESS [25:46 min]
[INFO] Jargon User Tagging ................................ SUCCESS [ 29.752 s]
[INFO] Jargon Data Utils .................................. SUCCESS [01:57 min]
[INFO] Jargon Ticket ...................................... SUCCESS [  7.319 s]
[INFO] Jargon Pool ........................................ SUCCESS [ 54.106 s]
[INFO] Jargon Rule Service ................................ SUCCESS [ 11.335 s]
[INFO] data-profile ....................................... SUCCESS [  5.177 s]
[INFO] jargon-zipservice .................................. SUCCESS [  3.092 s]
[INFO] Jargon Metadata Query .............................. SUCCESS [01:52 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS                                                           
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  31:29 min                                                  
[INFO] Finished at: 2023-12-02T19:30:07Z                                       
[INFO] ------------------------------------------------------------------------

Rerunning against 4.3.0 again.

trel · 2023-12-02T19:55:26Z

so good. go go go.

jargon-core/src/test/java/org/irods/jargon/core/pub/BulkFileOperationsAOImplTest.java

korydraughn · 2023-12-02T20:29:19Z

Another failure against 4.3.0.

[ERROR] testCreateBundleZip(org.irods.jargon.core.pub.BulkFileOperationsAOImplTest)  Time elapsed: 17.92 s  <<< ERROR!
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-77000
        at org.irods.jargon.core.pub.BulkFileOperationsAOImplTest.testCreateBundleZip(BulkFileOperationsAOImplTest.java:271)

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   BulkFileOperationsAOImplTest.testCreateBundleZip:271 » Jargon Unknown iRODS ex...

Skipping since it is fixed in 4.3.1.

korydraughn · 2023-12-03T15:38:58Z

Had to skip one user-tagging test for 4.3.0.

All tests pass against iRODS 4.3.0 now.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Jargon 4.3.3.0-RELEASE:                             
[INFO]                                                                         
[INFO] Jargon ............................................. SUCCESS [  0.867 s]
[INFO] Jargon Core ........................................ SUCCESS [30:07 min]
[INFO] Jargon User Tagging ................................ SUCCESS [ 29.610 s]
[INFO] Jargon Data Utils .................................. SUCCESS [01:53 min]
[INFO] Jargon Ticket ...................................... SUCCESS [  7.102 s]
[INFO] Jargon Pool ........................................ SUCCESS [ 50.907 s]
[INFO] Jargon Rule Service ................................ SUCCESS [ 10.332 s]
[INFO] data-profile ....................................... SUCCESS [  5.043 s]
[INFO] jargon-zipservice .................................. SUCCESS [  3.038 s]
[INFO] Jargon Metadata Query .............................. SUCCESS [01:59 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS                                                           
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  35:48 min                                                  
[INFO] Finished at: 2023-12-03T15:33:24Z                                       
[INFO] ------------------------------------------------------------------------

Running tests against iRODS 4.2.12.

korydraughn · 2023-12-03T16:39:53Z

All tests passed against iRODS 4.2.12.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Jargon 4.3.3.0-RELEASE:                             
[INFO]                                                                         
[INFO] Jargon ............................................. SUCCESS [  0.993 s]
[INFO] Jargon Core ........................................ SUCCESS [40:53 min]
[INFO] Jargon User Tagging ................................ SUCCESS [ 27.876 s]
[INFO] Jargon Data Utils .................................. SUCCESS [01:51 min]
[INFO] Jargon Ticket ...................................... SUCCESS [  6.948 s]
[INFO] Jargon Pool ........................................ SUCCESS [ 52.324 s]
[INFO] Jargon Rule Service ................................ SUCCESS [ 10.875 s]
[INFO] data-profile ....................................... SUCCESS [  5.191 s]
[INFO] jargon-zipservice .................................. SUCCESS [  2.961 s]
[INFO] Jargon Metadata Query .............................. SUCCESS [02:42 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS                                                           
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  47:15 min                                                  
[INFO] Finished at: 2023-12-03T16:38:25Z                                       
[INFO] ------------------------------------------------------------------------

Running against iRODS 4.3.1.

korydraughn · 2023-12-04T13:38:53Z

The tests passed against 4.3.1, but it required a few runs to get there. The failures I saw were all due to the Bulk/StructuredFile APIs. I'm going to run the tests again just so we capture the failures, but I don't think they are a blocker for this PR since we're planning on replacing those APIs.

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Jargon 4.3.3.0-RELEASE:                             
[INFO]                                                                         
[INFO] Jargon ............................................. SUCCESS [  0.947 s]
[INFO] Jargon Core ........................................ SUCCESS [25:41 min]
[INFO] Jargon User Tagging ................................ SUCCESS [ 28.538 s]
[INFO] Jargon Data Utils .................................. SUCCESS [01:49 min]
[INFO] Jargon Ticket ...................................... SUCCESS [  7.060 s]
[INFO] Jargon Pool ........................................ SUCCESS [ 53.919 s]
[INFO] Jargon Rule Service ................................ SUCCESS [ 11.374 s]
[INFO] data-profile ....................................... SUCCESS [  5.160 s]
[INFO] jargon-zipservice .................................. SUCCESS [  2.958 s]
[INFO] Jargon Metadata Query .............................. SUCCESS [01:44 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS                                                           
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  31:06 min                                                  
[INFO] Finished at: 2023-12-04T03:01:46Z                                       
[INFO] ------------------------------------------------------------------------

korydraughn · 2023-12-04T14:33:09Z

Here's the failure I'm seeing against 4.3.1.

[ERROR] Tests run: 1553, Failures: 0, Errors: 1, Skipped: 4, Time elapsed: 1,417.961 s <<< FAILURE! - in org.irods.jargon.core.unittest.AllTests
[ERROR] testCreateBundleZip(org.irods.jargon.core.pub.BulkFileOperationsAOImplTest)  Time elapsed: 1.927 s  <<< ERROR!                          
org.irods.jargon.core.exception.JargonException: Unknown iRODS exception code recieved:-77000                                                   
        at org.irods.jargon.core.pub.BulkFileOperationsAOImplTest.testCreateBundleZip(BulkFileOperationsAOImplTest.java:275)                    
                                                                                                                                                
[INFO]                                                                                                                                          
[INFO] Results:                                                                                                                                 
[INFO]                                                                                                                                          
[ERROR] Errors:                                                                                                                                 
[ERROR]   BulkFileOperationsAOImplTest.testCreateBundleZip:275 » Jargon Unknown iRODS ex...                                                     
[INFO]                                                                                                                                          
[ERROR] Tests run: 1553, Failures: 0, Errors: 1, Skipped: 4                                                                                     
[INFO]                                                                                                                                          
[INFO] ------------------------------------------------------------------------                                                                 
[INFO] Reactor Summary for Jargon 4.3.3.0-RELEASE:                                                                                              
[INFO]                                                                                                                                          
[INFO] Jargon ............................................. SUCCESS [  0.982 s]                                                                 
[INFO] Jargon Core ........................................ FAILURE [25:23 min]                                                                 
[INFO] Jargon User Tagging ................................ SKIPPED

Rerunning that test (without relaunching the docker containers) results in the test passing. That indicates the test may not be idempotent.

Rerunning all tests (without relaunching the docker containers) in BulkFileOperationsAOImplTest pass too.

The failure only occurs when running from a fresh environment (i.e. no previous run has occurred).

korydraughn · 2023-12-04T16:01:29Z

Created #435 for the failing test.

This isn't a blocker for this PR.

…3 permission levels.

This was referenced Nov 21, 2023

TLS/SSL, Docker, and code tweaks irods/irods_client_nfsrods#194

Merged

When I try to run Docker container, the error [SSL is required on the server, but not on the client] is output. irods/irods_client_nfsrods#193

Closed

korydraughn commented Nov 30, 2023

View reviewed changes

korydraughn force-pushed the server_negotiation.m branch from 3e931d5 to 52edb9b Compare December 1, 2023 14:35

korydraughn force-pushed the server_negotiation.m branch from 08f56f8 to 6486b6c Compare December 1, 2023 19:32

korydraughn commented Dec 2, 2023

View reviewed changes

jargon-core/src/test/java/org/irods/jargon/core/pub/BulkFileOperationsAOImplTest.java Outdated Show resolved Hide resolved

jargon-core/src/test/java/org/irods/jargon/core/pub/BulkFileOperationsAOImplTest.java Outdated Show resolved Hide resolved

korydraughn mentioned this pull request Dec 4, 2023

Skip BulkFileOperationsAOImplTest test when testing against iRODS 4.3.0 and later #435

Closed

korydraughn force-pushed the server_negotiation.m branch from 15a93b8 to d20cbf8 Compare December 4, 2023 16:53

korydraughn and others added 7 commits December 4, 2023 11:55

[DICE-UNC#429] Send correct <option> value for StartupPack.

ea62f27

[DICE-UNC#429] Adjust failing tests for iRODS 4.3 changes.

776caed

[DICE-UNC#432] Add server version detection methods for iRODS 4.3.

8f59cdf

[DICE-UNC#428] Make FilePermissionEnum support newly exposed iRODS 4.…

3d94112

…3 permission levels.

[DICE-UNC#433] Rename docker test directory from "latest" to "4-3".

f6ef09b

[DICE-UNC#434] Expose Docker build option for iRODS package version.

0819adc

[DICE-UNC#431] Disable port mappings in docker test framework.

e609b41

korydraughn force-pushed the server_negotiation.m branch from d20cbf8 to e609b41 Compare December 4, 2023 16:56

korydraughn merged commit f4ea299 into DICE-UNC:master Dec 4, 2023
1 of 2 checks passed

korydraughn deleted the server_negotiation.m branch December 4, 2023 16:58

korydraughn mentioned this pull request Aug 12, 2024

Investigate BulkFileOperationsAOImplTest test failure against iRODS 4.3.0 and later #457

Open

korydraughn mentioned this pull request Aug 29, 2024

add connection naming to startup pack #352

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#429] Send correct `<option>` value for StartupPack #430

[#429] Send correct `<option>` value for StartupPack #430

korydraughn commented Nov 21, 2023 •

edited

Loading

korydraughn commented Nov 28, 2023 •

edited

Loading

korydraughn commented Nov 28, 2023

korydraughn commented Nov 28, 2023

trel commented Nov 28, 2023

korydraughn commented Nov 28, 2023

korydraughn commented Nov 29, 2023

korydraughn commented Nov 30, 2023 •

edited

Loading

korydraughn commented Nov 30, 2023

korydraughn commented Nov 30, 2023

korydraughn commented Dec 1, 2023

korydraughn commented Dec 1, 2023

korydraughn commented Dec 1, 2023

korydraughn commented Dec 2, 2023 •

edited

Loading

korydraughn commented Dec 2, 2023

korydraughn commented Dec 2, 2023

trel commented Dec 2, 2023

korydraughn commented Dec 2, 2023

korydraughn commented Dec 3, 2023

korydraughn commented Dec 3, 2023

korydraughn commented Dec 4, 2023

korydraughn commented Dec 4, 2023

korydraughn commented Dec 4, 2023

[#429] Send correct <option> value for StartupPack #430

[#429] Send correct <option> value for StartupPack #430

Conversation

korydraughn commented Nov 21, 2023 • edited Loading

korydraughn commented Nov 28, 2023 • edited Loading

korydraughn commented Nov 28, 2023

korydraughn commented Nov 28, 2023

trel commented Nov 28, 2023

korydraughn commented Nov 28, 2023

korydraughn commented Nov 29, 2023

korydraughn commented Nov 30, 2023 • edited Loading

korydraughn commented Nov 30, 2023

korydraughn commented Nov 30, 2023

korydraughn commented Dec 1, 2023

korydraughn commented Dec 1, 2023

korydraughn commented Dec 1, 2023

korydraughn commented Dec 2, 2023 • edited Loading

korydraughn commented Dec 2, 2023

korydraughn commented Dec 2, 2023

trel commented Dec 2, 2023

korydraughn commented Dec 2, 2023

korydraughn commented Dec 3, 2023

korydraughn commented Dec 3, 2023

korydraughn commented Dec 4, 2023

korydraughn commented Dec 4, 2023

korydraughn commented Dec 4, 2023

[#429] Send correct `<option>` value for StartupPack #430

[#429] Send correct `<option>` value for StartupPack #430

korydraughn commented Nov 21, 2023 •

edited

Loading

korydraughn commented Nov 28, 2023 •

edited

Loading

korydraughn commented Nov 30, 2023 •

edited

Loading

korydraughn commented Dec 2, 2023 •

edited

Loading