Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v7r3] Start running integration tests with a Python 3 server #5000

Merged
merged 9 commits into from
Apr 29, 2021

Conversation

chrisburr
Copy link
Member

@chrisburr chrisburr commented Mar 1, 2021

Includes #5094 #5088 #5087 #5086 #5078 #5092. The new bits of this can be see in this diff and includes:

  • df947b9 Add ConfigTemplate.cfg and *.sql files to Python 3 sdist/bdist
  • 69c458c Enable integration tests for Python 3 servers
  • 834f457 Various minor Python 3 compatibility fixes
  • ad52997 Factorise recurseImport to DIRAC.Core.Utilities.Extensions
  • 52914e3 Use DIRAC.Core.Utilities.Extensions in ComponentInstaller
  • 7205344 Mostly replace getCSExtensions and various object loading clean-ups

The biggest change is to get Python 3 server installations to be mostly functional (at least for the tests). As part of this I've also:

  • Simplified the recursive importing to use the recurseImport implementation in Core.Utilities.Extensions
  • Deprecated CSGlobals.getInstalledExtensions
  • Removed most uses of getCSExtensions. I haven't formally deprecated it as it's still used but it shouldn't be used when running with Python 3.
  • Various refactoring, most notably inside the module/object loading and the ComponentInstaller

BEGINRELEASENOTES

  • Configuration
    CHANGE: Deprecate CSGlobals.getInstalledExtensions, DIRAC.Core.Utilities.Extensions.extensionsByPriority should be used instead
    CHANGE: Deprecate getCSExtensions, DIRAC.Core.Utilities.Extensions.extensionsByPriority should be used instead

*Python 3
NEW: Initial support for Python 3 server installations

ENDRELEASENOTES

@chrisburr chrisburr force-pushed the server-py3 branch 3 times, most recently from 6ed38a6 to ec87743 Compare March 2, 2021 07:03
@chrisburr chrisburr linked an issue Mar 2, 2021 that may be closed by this pull request
@chrisburr chrisburr force-pushed the server-py3 branch 2 times, most recently from af49c42 to 2f3f665 Compare March 8, 2021 15:34
@chrisburr chrisburr force-pushed the server-py3 branch 4 times, most recently from 819d10a to b62de19 Compare March 18, 2021 21:02
tests/Integration/all_integration_client_tests.sh Outdated Show resolved Hide resolved
tests/Jenkins/utilities.sh Outdated Show resolved Hide resolved
tests/Jenkins/utilities.sh Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
src/DIRAC/__init__.py Show resolved Hide resolved
Copy link
Contributor

@fstagni fstagni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not easy to review these changes, so I may well have missed some important points. Nevertheless, it looks OK.

@chrisburr
Copy link
Member Author

@atsareg Same for this one

@atsareg atsareg merged commit 8824edc into DIRACGrid:integration Apr 29, 2021
@chrisburr chrisburr deleted the server-py3 branch April 29, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Run integration tests with a Python 3 server installation
3 participants