-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v7r3] Start running integration tests with a Python 3 server #5000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisburr
force-pushed
the
server-py3
branch
3 times, most recently
from
March 2, 2021 07:03
6ed38a6
to
ec87743
Compare
chrisburr
force-pushed
the
server-py3
branch
2 times, most recently
from
March 8, 2021 15:34
af49c42
to
2f3f665
Compare
chrisburr
force-pushed
the
server-py3
branch
4 times, most recently
from
March 18, 2021 21:02
819d10a
to
b62de19
Compare
fstagni
reviewed
Mar 25, 2021
chrisburr
force-pushed
the
server-py3
branch
6 times, most recently
from
April 6, 2021 15:47
933786b
to
0f4139e
Compare
Merged
chrisburr
force-pushed
the
server-py3
branch
2 times, most recently
from
April 15, 2021 09:42
efbac8d
to
271eb44
Compare
fstagni
approved these changes
Apr 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not easy to review these changes, so I may well have missed some important points. Nevertheless, it looks OK.
@atsareg Same for this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #5094 #5088 #5087 #5086 #5078 #5092. The new bits of this can be see in this diff and includes:
The biggest change is to get Python 3 server installations to be mostly functional (at least for the tests). As part of this I've also:
recurseImport
implementation inCore.Utilities.Extensions
CSGlobals.getInstalledExtensions
getCSExtensions
. I haven't formally deprecated it as it's still used but it shouldn't be used when running with Python 3.ComponentInstaller
BEGINRELEASENOTES
CHANGE: Deprecate CSGlobals.getInstalledExtensions, DIRAC.Core.Utilities.Extensions.extensionsByPriority should be used instead
CHANGE: Deprecate getCSExtensions, DIRAC.Core.Utilities.Extensions.extensionsByPriority should be used instead
*Python 3
NEW: Initial support for Python 3 server installations
ENDRELEASENOTES