-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v8.0] fix (Transformation): use parameterised query in addTransformation #7894
Merged
fstagni
merged 2 commits into
DIRACGrid:rel-v8r0
from
ryuwd:roneil-make-it-so-i-can-submit-transformations
Nov 20, 2024
Merged
[v8.0] fix (Transformation): use parameterised query in addTransformation #7894
fstagni
merged 2 commits into
DIRACGrid:rel-v8r0
from
ryuwd:roneil-make-it-so-i-can-submit-transformations
Nov 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DIRACGridBot
added
the
alsoTargeting:integration
Cherry pick this PR to integration after merge
label
Nov 18, 2024
andresailer
reviewed
Nov 18, 2024
andresailer
reviewed
Nov 18, 2024
ryuwd
changed the title
[rel-v8r0] fix (Transformation): escape parameters in addTransformation
[rel-v8r0] fix (Transformation): escape parameters in addTransformation / support submitting Transformations by people with apostrophes in their name
Nov 18, 2024
the failing tests are suspicious
possible that |
ryuwd
force-pushed
the
roneil-make-it-so-i-can-submit-transformations
branch
from
November 18, 2024 21:16
fa08ef4
to
895af75
Compare
I combed the cc @chrisburr |
ryuwd
changed the title
[rel-v8r0] fix (Transformation): escape parameters in addTransformation / support submitting Transformations by people with apostrophes in their name
[v8.0] fix (Transformation): use parameterised query in addTransformation
Nov 18, 2024
ryuwd
force-pushed
the
roneil-make-it-so-i-can-submit-transformations
branch
from
November 18, 2024 21:44
895af75
to
cfc8e73
Compare
ryuwd
force-pushed
the
roneil-make-it-so-i-can-submit-transformations
branch
from
November 18, 2024 21:45
cfc8e73
to
caab09b
Compare
chrisburr
reviewed
Nov 19, 2024
chrisburr
reviewed
Nov 19, 2024
…e parameterised query instead.
chrisburr
approved these changes
Nov 19, 2024
DIRACGridBot
added
sweep:done
All sweeping actions have been done for this PR
sweep:failed
Sweeping failed and needs manual intervention
labels
Nov 20, 2024
Sweep summary Sweep ran in https://github.com/DIRACGrid/DIRAC/actions/runs/11929703771 Failed:
|
fstagni
added a commit
to fstagni/DIRAC
that referenced
this pull request
Dec 4, 2024
…n addTransformation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
alsoTargeting:integration
Cherry pick this PR to integration after merge
sweep:done
All sweeping actions have been done for this PR
sweep:failed
Sweeping failed and needs manual intervention
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so I am able to submit transformations despite my name having an apostrophe in it.Use a parameterised query in addTransformation to sidestep issues around escaping.BEGINRELEASENOTES
*Transformation
FIX: Use parameterised query in addTransformation
ENDRELEASENOTES