Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added jsonrpc for autorest #364

Closed
wants to merge 2 commits into from
Closed

Conversation

fstagni
Copy link
Contributor

@fstagni fstagni commented Jan 10, 2025

No description provided.

@fstagni
Copy link
Contributor Author

fstagni commented Jan 10, 2025

The CI for the other PRs is failing to run autorest, with message like

 Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/runner/.autorest/@[email protected]/node_modules/@autorest/python/autorest/jsonrpc/server.py", line 12, in <module>
    from jsonrpc import dispatcher, JSONRPCResponseManager
ModuleNotFoundError: No module named 'jsonrpc'

so I simply added jsonrpc in this PR and now autorest works. It turns out that now pip check fails. So, question is, should I add jsonrpc in the container images?

@fstagni
Copy link
Contributor Author

fstagni commented Jan 10, 2025

The CI for the other PRs is failing to run autorest, with message like

 Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/runner/.autorest/@[email protected]/node_modules/@autorest/python/autorest/jsonrpc/server.py", line 12, in <module>
    from jsonrpc import dispatcher, JSONRPCResponseManager
ModuleNotFoundError: No module named 'jsonrpc'

so I simply added jsonrpc in this PR and now autorest works. It turns out that now pip check fails. So, question is, should I add jsonrpc in the container images?

Oh and I did not check why it "suddenly" fails, it's probably because of some dependency dropped somewhere.

@fstagni
Copy link
Contributor Author

fstagni commented Jan 13, 2025

Looks like not needed.

@fstagni fstagni closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant