-
-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add Mojo #285
base: main
Are you sure you want to change the base?
[WIP] Add Mojo #285
Conversation
It is a start, but readme and license stuff needs updating too. |
You still have the Atelier submodule there. Also it would be "better" to do the panel graphic mods in code, rather than forking the repo with modified assets. |
one step at a time. the PR already gives a head start for these modules, which is nice :) |
I added atelier myself, I thought pull requests were only for the relevant commit? Should I make another repo without Atelier? I don't understand the necessary code for that and it's really not worth it for me to learn it just to do that. |
You need to split each pull request per branch, otherwise this pull request gets all the changes. In any case, Atelier is currently blocked as we did not get permission to use their artwork. |
Okay I removed it. |
I was wondering if I asked dev do include my dark versions in the official modules repo if that would make things easier if he accepted? |
e3644fb
to
ae04997
Compare
Best to use upstream sources when possible, we can do the dark mode ourselves at runtime. I checked on this finally, and there is a license issue. Opened a ticket at tomdasilva/Mojo#4 |
bfa0c80
to
fad9257
Compare
6e4f5ca
to
6655ba0
Compare
54b0ec1
to
d3b722e
Compare
a30e278
to
f7a919f
Compare
0cba0a1
to
80bda51
Compare
@falkTX and @dromer, the developer said they have corrected the licensing error tomdasilva/Mojo#4 (comment) . |
@TheGuyWhoo can you update your branch with the latest Cardinal main and Mojo release changes? You also still need to add to the Readme and License info. |
58e55b0
to
52d71a1
Compare
7251c87
to
61f2d29
Compare
Well this builds and the panels are now dark. I took a look at the examples of bidoo and impromptu dark and yeah I don't understand what's going on there so I just made a repo. Cheers.