Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AlliewayAudio_Freebies. #731

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

rl2939
Copy link
Contributor

@rl2939 rl2939 commented Nov 11, 2024

Adds the only module from AlliewayAudio_Freebies.

@dromer
Copy link
Collaborator

dromer commented Nov 11, 2024

LTO reveals that DCBlocker is already a type in another module.

You will need to set ALLIEWAYAUDIO_FREEBIES_CUSTOM = DCBlocker in the Makefile.

@dromer
Copy link
Collaborator

dromer commented Nov 12, 2024

Hmm, I'm thinking we should have a dark panel for allieway. they don't have one themselves but we can apply some inverting logic like we do for other modules.

This is done here: https://github.com/DISTRHO/Cardinal/blob/main/src/custom/dep.cpp

@dromer
Copy link
Collaborator

dromer commented Nov 12, 2024

I tried a basic inversion of the panel which is not super bad, but could be better:

Logo should still be pink and I think the panel is a bit too dark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants