Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added eightfold. #735

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Added eightfold. #735

wants to merge 2 commits into from

Conversation

rl2939
Copy link
Contributor

@rl2939 rl2939 commented Nov 13, 2024

Added the eightfold modules.

@rl2939
Copy link
Contributor Author

rl2939 commented Nov 13, 2024

How do I fix the build error that the checks are complaining about (below)? It builds without error on my machine.

eightfold/src/SDOrcasHeartV2.cpp:320:33: error: 'constexpr rack::dsp::TSchmittTrigger<float>::<unnamed union>::<constructor>()' is inaccessible within this context
  320 |     dsp::SchmittTrigger clockIn{}, resetIn{}, scaleSwitchTrig{}, scaleInputTrig{};
      |                                 ^
In file included from /__w/Cardinal/Cardinal/src/Rack/include/rack.hpp:122,
                 from eightfold/src/plugin.hpp:1,
                 from eightfold/src/SDOrcasHeartV2.cpp:1:
/__w/Cardinal/Cardinal/src/Rack/include/dsp/digital.hpp:89:8: note: declared here
   89 |  union {
      |        ^
eightfold/src/SDOrcasHeartV2.cpp:320:44: error: 'constexpr rack::dsp::TSchmittTrigger<float>::<unnamed union>::<constructor>()' is inaccessible within this context
  320 |     dsp::SchmittTrigger clockIn{}, resetIn{}, scaleSwitchTrig{}, scaleInputTrig{};
      |                                            ^
In file included from /__w/Cardinal/Cardinal/src/Rack/include/rack.hpp:122,
                 from eightfold/src/plugin.hpp:1,
                 from eightfold/src/SDOrcasHeartV2.cpp:1:
/__w/Cardinal/Cardinal/src/Rack/include/dsp/digital.hpp:89:8: note: declared here
   89 |  union {
      |        ^
eightfold/src/SDOrcasHeartV2.cpp:320:63: error: 'constexpr rack::dsp::TSchmittTrigger<float>::<unnamed union>::<constructor>()' is inaccessible within this context
  320 |     dsp::SchmittTrigger clockIn{}, resetIn{}, scaleSwitchTrig{}, scaleInputTrig{};
      |                                                               ^
In file included from /__w/Cardinal/Cardinal/src/Rack/include/rack.hpp:122,
                 from eightfold/src/plugin.hpp:1,
                 from eightfold/src/SDOrcasHeartV2.cpp:1:
/__w/Cardinal/Cardinal/src/Rack/include/dsp/digital.hpp:89:8: note: declared here
   89 |  union {
      |        ^
eightfold/src/SDOrcasHeartV2.cpp:320:81: error: 'constexpr rack::dsp::TSchmittTrigger<float>::<unnamed union>::<constructor>()' is inaccessible within this context
  320 |     dsp::SchmittTrigger clockIn{}, resetIn{}, scaleSwitchTrig{}, scaleInputTrig{};
      |                                                                                 ^
In file included from /__w/Cardinal/Cardinal/src/Rack/include/rack.hpp:122,
                 from eightfold/src/plugin.hpp:1,
                 from eightfold/src/SDOrcasHeartV2.cpp:1:
/__w/Cardinal/Cardinal/src/Rack/include/dsp/digital.hpp:89:8: note: declared here
   89 |  union {
      |        ^
make[1]: *** [Makefile:2365: ../build/plugins/eightfold/src/SDOrcasHeartV2.cpp.o] Error 1

@rl2939 rl2939 marked this pull request as draft November 15, 2024 00:52
@falkTX
Copy link
Contributor

falkTX commented Nov 26, 2024

maybe this needs c++17 too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants