Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credentials.md #869

Merged
merged 3 commits into from
Dec 15, 2024
Merged

Update credentials.md #869

merged 3 commits into from
Dec 15, 2024

Conversation

ser1aa
Copy link
Contributor

@ser1aa ser1aa commented Nov 12, 2024

Rephrased some sentences (trying to not change the message) and removed some spelling mistakes.

Rephrased some sentences (trying to not change the message) and removed some spelling mistakes.
Copy link
Contributor

@MrSeccubus MrSeccubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Een paar kleine dingen. Kun je er nog even naar kijken?


### Does it help?

Lots of credentials are from so called [combo lists](https://scirge.com/glossary/combo-list). Credentials from different breaches, combined, traded and often of low quality. Most of the time these lists only contain a username and password and are devoid of any context like when the the credentials were "harvested", which platform, service or system they initially belonged to and where the breach occured.
Lots of credentials are from so-called [combo lists](https://scirge.com/glossary/combo-list). These lists combine credentials from different breaches, are traded, and are often of low quality. Most of the time, these lists only contain a username and password and are devoid of any context, like when the credentials were "harvested," which platform, service, or system they initially belonged to, and where the breach occurred.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Lots of credentials are from so-called [combo lists](https://scirge.com/glossary/combo-list). These lists combine credentials from different breaches, are traded, and are often of low quality. Most of the time, these lists only contain a username and password and are devoid of any context, like when the credentials were "harvested," which platform, service, or system they initially belonged to, and where the breach occurred.
Lots of credentials are from so-called [combo lists](https://scirge.com/glossary/combo-list). These lists combine credentials from different breaches, are traded, and are often of low quality. Most of the time, these lists only contain a username and password and are devoid of any context, like when the credentials were "harvested", which platform, service, or system they initially belonged to, and where the breach occurred.

Ik vind die comma raar staan binnen de quotes, ligt dat aan mij?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De comma staat daar om de leesbaarheid van te verbeteren. Zonder de comma klopt de zin niet meer

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dat snap ik maar dan schrijf je toch ”harvested”, ipv ”harvested,”

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, je hebt gelijk

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Het lukt mij niet om het pull request aan te passen, kan jij dat doen eventueel @MrSeccubus ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#894
PR staat open om het op te lossen

Deze PR is al merged

credentials.md Outdated Show resolved Hide resolved
credentials.md Outdated Show resolved Hide resolved
credentials.md Outdated Show resolved Hide resolved
Feedback van Frank verwerkt.
Copy link
Contributor Author

@ser1aa ser1aa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beter zo?

Copy link
Contributor

@JstRelax JstRelax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

De score is gebaseerd op 0 tot 1
Dus dit dient 0.4 te zijn.

credentials.md Outdated Show resolved Hide resolved
Co-authored-by: Stan Plasmeijer <[email protected]>
Copy link
Contributor

@MrSeccubus MrSeccubus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MrSeccubus MrSeccubus merged commit e593f87 into DIVD-NL:main Dec 15, 2024
2 checks passed
@JstRelax JstRelax mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants