Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search_query callback #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ole-alb
Copy link

@ole-alb ole-alb commented Oct 24, 2024

Update png2mesh to match the changed search_query callback from t8code, which was updated in:
split search_query callback function into two
and
Changed return type of query function to void

@holke
Copy link
Collaborator

holke commented Oct 25, 2024

Great changes, thank you!

Did you test the code?

I think this now raises the dependency on t8code to 3.0.0? Then we should add that in the CMake file

@ole-alb
Copy link
Author

ole-alb commented Oct 25, 2024

I tested it by running the demo and by executing it with different pngs.

Yeah we should add t8code 3.0.0 as soon as we made the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants