-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Testsuite Preview github action #126
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: George Cosma <[email protected]>
Note, current check fails due to main branch not producing a w/r/t to the nix workflow, I'll fix it later, until then I am ready to hear your opinions on this |
Looks great, I think it's looks fair enough as far as seperation of concerns are concerned at the very beginning, we can change things up later. Once nix deps are added we can merge I think. |
I'm not sure what you mean by "seperation of concerns" or what "nix dependencies" are referencing |
By seperation of concerns i mean what the python script does, where in the python script, or rust tests etc. By nix deps I meant the packages that have to be mentioned in the flake as a test dependency / devshell for the python script |
I understand that the python script has no external dependencies, simply putting pkgs.python3 into the devshell could work already? |
Signed-off-by: Cem Onem <[email protected]>
Signed-off-by: Cem Onem <[email protected]>
The contents of the devshell command I added looks bad but fair enough i guess, if there are better ways to write it, be my guest 😅 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
Pull Request Overview
This pull request adds a sticky comment that shows differences between testsuite runs. For example, see george-cosma#11
Based on @nerodesu017 implementation #125
Testing Strategy
This pull request was tested here: george-cosma#11
TODO or Help Wanted
Just as a note, when I tried modifying I32 sub the interpreter ran into an infinite loop. This should be investigated.
Also, this does add a python script. I will want to make another script that tests the speed of our interpreter against a reference program. This script will need to compile another rust program, and storing it in main seems.... weird. Suggestions/Is this a non-issue?
Formatting
cargo fmt
cargo check
cargo build
cargo doc
nix fmt