Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wasm official testsuite bug hunt #127

Merged
merged 5 commits into from
Feb 19, 2025
Merged

fix: wasm official testsuite bug hunt #127

merged 5 commits into from
Feb 19, 2025

Conversation

cemonem
Copy link

@cemonem cemonem commented Feb 14, 2025 •
edited
Loading

Pull Request Overview

so far return type check was fixed.

Formatting

  • Ran cargo fmt
  • Ran cargo check
  • Ran cargo build
  • Ran cargo doc
  • Ran nix fmt

@cemonem cemonem added bug Something isn't working and removed priority-high execution labels Feb 14, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 14, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/validation/code.rs 95.83% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/execution/interpreter_loop.rs 99.03% <100.00%> (-0.05%) ⬇️
src/execution/mod.rs 93.54% <100.00%> (-0.15%) ⬇️
src/validation/code.rs 83.68% <95.83%> (+0.39%) ⬆️

... and 2 files with indirect coverage changes

@george-cosma
Copy link
Collaborator

Could you please write some tests that would fail due to this bug but now succeed thanks to your fix(es)? Just so we don't have it happen again.

test: add tests for call_indirect runtime type check, types of ifs wi…
6d5839e 
…thout elses, invoke methods return type order

Signed-off-by: Cem Onem <[email protected]>
@cemonem cemonem force-pushed the dev/cemonem-wasm-testsuite-bug-fixes branch from 6b51a50 to 6d5839e Compare February 18, 2025 12:13
@george-cosma george-cosma added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit b24b042 Feb 19, 2025
12 checks passed
@george-cosma george-cosma deleted the dev/cemonem-wasm-testsuite-bug-fixes branch February 19, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@george-cosma george-cosma george-cosma approved these changes

@nerodesu017 nerodesu017 nerodesu017 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working execution priority-high priority-medium tests validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cemonem @george-cosma @nerodesu017