Enable function invocation by name

[george-cosma]

Pull Request Overview

This pull request adds the ability to invoke a function using its name rather than its id.

This feature is needed as part of parsing wast files. Their equivalent of assert uses the name of functions. Relevant issue: #9

Testing Strategy

This pull request was tested by modifying the add_one integration test to invoke its function by name rather than by index.

TODO or Help Wanted

This pull request still needs...

• Change all tests to use named invocation (Q: Do we want to do this, or let the old tests as-is?)
• Q: Should RuntimeInstance be responsible for holding onto the exports?

Formatting

• Ran cargo fmt
• Ran cargo check
• Ran cargo build
• Ran nix fmt
• Ran treefmt

Author

Signed-off-by: George Cosma [email protected]

[george-cosma]

PR marked as draft until I get some feedback for the question in the "Todo section"

[nerodesu017]

lgtm

[valexandru]

Looks good also to me. I see the value in modifying the other tests so that the code is more readable.
Regarding the question, what does it mean holding onto the exports? Storing the references to them? I think so.

[florianhartung]

Change all tests to use named invocation (Q: Do we want to do this, or let the old tests as-is?)

Using named invocations in the tests does not really have any downsides and provides better readability, so I'd say it's worth it.

---

Should RuntimeInstance be responsible for holding onto the exports?

Yes, the RuntimeInstance is our equivalent of the Module Instance as specified by the WASM Spec

[wucke13]

The changes lgtm, however I would wish for the commit history to be reworked into two commits, one for the initial draft, one for the change of the tests.

[wucke13]

@george-cosma please refactor the two commit messages to be compliant with conventional commit. If you rebase from main, you will also get a CI check for that.

[george-cosma]

Done 👍