Code

generalize linechart settings#388

Code

Draft

kunkoala wants to merge 69 commits intodevelopDLR-SC/ESID:developfrom feat/generalized-linechart-settingsDLR-SC/ESID:feat/generalized-linechart-settingsCopy head branch name to clipboard

+2,240-330

Commits

Commits on Sep 16, 2024

• 🎉 Added a new hook and use that hook to be able to add an axis range on a specific value of y-axis

  kunkoala

  committed
  62a6cdd

  Copy full SHA for 62a6cdd

Commits on Sep 17, 2024

• 🔧 Refactor LineChart component to use horizontalYAxisThreshold instead of horizontalYLimit

  kunkoala

  committed
  3eecb4a

  Copy full SHA for 3eecb4a

• 🎉 Added settings button to lineChartContainer, now horizontalYAxisThreshold is saved in UserPreferenceSlice.ts and could be adjusted through LineChartSettings

  kunkoala

  committed
  8d0c165

  Copy full SHA for 8d0c165

Commits on Sep 18, 2024

• 🎉 added a new hook for creating series range, and use it with useLineSeries to create all ranges (wonder if this approach worked)

  kunkoala

  committed
  5b2fbd3

  Copy full SHA for 5b2fbd3

Commits on Sep 27, 2024

• 🔧 🔨 make a seriesRangeSettings to use for the series range, and updated the seriesRange settings to accept optional parameter so that the horizontal line is undefined when there's no horizontalYAxis

  kunkoala

  committed
  4e56f95

  Copy full SHA for 4e56f95

• 🔧 🔨 Update LineChartSettings to use selected district and compartment for horizontal Y-axis threshold

  kunkoala

  committed
  6a469f4

  Copy full SHA for 6a469f4

• 🔧 small code refactors

  kunkoala

  committed
  4be3f67

  Copy full SHA for 4be3f67

• ✨ Fixed formatting issues

  kunkoala

  committed
  df75997

  Copy full SHA for df75997

Commits on Sep 30, 2024

• ✨ added license

  kunkoala

  committed
  b775110

  Copy full SHA for b775110

• 🔧 🔨 refactored district data type and use it on different files

  kunkoala

  committed
  0b1e1e8

  Copy full SHA for 0b1e1e8

• 🔧 edited some functions for horizontal threshold slice in UserPreferenceSlice

  kunkoala

  committed
  7f5a751

  Copy full SHA for 7f5a751

Commits on Oct 7, 2024

• 🎉 🔧 🔨 refactored some file structures, added line chart settings menu to the bottom left that is customizable and able to add new menus such as filters, added a horizontal line settings menu that i…

  Show description for ef94f5d
  kunkoala

  committed
  ef94f5d

  Copy full SHA for ef94f5d

• 🔧 ✨ added some error handlings and for adding a new threshold and some refactors

  kunkoala

  committed
  d7ac19c

  Copy full SHA for d7ac19c

• 🔧 Set horizontal thresholds in store

  kunkoala

  committed
  3431d24

  Copy full SHA for 3431d24

• ✨ add license to type

  kunkoala

  committed
  16be2a5

  Copy full SHA for 16be2a5

Commits on Oct 8, 2024

• 🔧 refactor some state names to adhere to naming conventions

  kunkoala

  committed
  3794379

  Copy full SHA for 3794379

• 🔧 🎉 added a useEffect to change the selected map area when the district store changes

  kunkoala

  committed
  da16f93

  Copy full SHA for da16f93

• 🎉 🔨 refactor HorizontalThresholdList into HorizontalThresholdList- and Item, now highlights selected area based on the current selected district and compartment

  kunkoala

  committed
  2b2e7f4

  Copy full SHA for 2b2e7f4

• 🔧 added some conditionals to prevent unnecessary re-renders

  kunkoala

  committed
  6575e17

  Copy full SHA for 6575e17

• 🔧 🔨 🎉 ❇️ distinct styling for selected threshold and logic, refactor threshold input component and code style

  kunkoala

  committed
  12f9319

  Copy full SHA for 12f9319

• 🔧 useEffect dependencies

  kunkoala

  committed
  0565529

  Copy full SHA for 0565529

Commits on Oct 10, 2024

• 🔧 use useRef for selected area and update the compartments to change when the store changes

  kunkoala

  committed
  71564d3

  Copy full SHA for 71564d3

Commits on Oct 11, 2024

• 🔧 🔨 use MUI Table for the threshold list

  kunkoala

  committed
  1f4792d

  Copy full SHA for 1f4792d

Commits on Oct 15, 2024

• ✔️ add new userPreferenceSlice test to include threshold

  kunkoala

  committed
  24113b1

  Copy full SHA for 24113b1

Commits on Oct 18, 2024

• 🔨 ❇️ refactored horizontal threshold components, added test id for testing

  kunkoala

  committed
  b9ff42d

  Copy full SHA for b9ff42d

Commits on Oct 22, 2024

• 🔧 improved UX by disabling clicking other items when user is editing / adding a new threshold, improved styling, added some testid

  kunkoala

  committed
  855c213

  Copy full SHA for 855c213

• ✔️ created tests for HorizontalThreshold components and UserPreferenceSlice

  kunkoala

  committed
  d56b863

  Copy full SHA for d56b863

• 🔧 🪲 fixed import statement case for FilterValue in DataCard.test.tsx

  kunkoala

  committed
  5cf7656

  Copy full SHA for 5cf7656

• 🔧 ✨ 💚 added missing reuse compliance

  kunkoala

  committed
  5866381

  Copy full SHA for 5866381

Commits on Oct 29, 2024

• 🔧 🪲 small refactor and bug fix

  kunkoala

  committed
  674bd5a

  Copy full SHA for 674bd5a

• 🎉 🔧 added localization for settings menu and horizontal threshold

  kunkoala

  committed
  42a8b76

  Copy full SHA for 42a8b76

Commits on Oct 30, 2024

• 💚 fix license

  kunkoala

  committed
  e3b5c60

  Copy full SHA for e3b5c60

Commits on Nov 18, 2024

• 🎉 🔧 generalized the settings menu as a popover, moved the filterComponents to LineChartSettings

  kunkoala

  committed
  e6db800

  Copy full SHA for e6db800

• 🎉 Added a new hook and use that hook to be able to add an axis range on a specific value of y-axis

  kunkoala

  committed
  3911421

  Copy full SHA for 3911421

• 🔧 Refactor LineChart component to use horizontalYAxisThreshold instead of horizontalYLimit

  kunkoala

  committed
  dadda61

  Copy full SHA for dadda61

• 🎉 Added settings button to lineChartContainer, now horizontalYAxisThreshold is saved in UserPreferenceSlice.ts and could be adjusted through LineChartSettings

  kunkoala

  committed
  138a038

  Copy full SHA for 138a038

• 🎉 added a new hook for creating series range, and use it with useLineSeries to create all ranges (wonder if this approach worked)

  kunkoala

  committed
  ccb47fe

  Copy full SHA for ccb47fe

• 🔧 🔨 make a seriesRangeSettings to use for the series range, and updated the seriesRange settings to accept optional parameter so that the horizontal line is undefined when there's no horizontalYAxis

  kunkoala

  committed
  1e1a478

  Copy full SHA for 1e1a478

• 🔧 🔨 Update LineChartSettings to use selected district and compartment for horizontal Y-axis threshold

  kunkoala

  committed
  f26da1f

  Copy full SHA for f26da1f

• 🔧 small code refactors

  kunkoala

  committed
  69fcba6

  Copy full SHA for 69fcba6

• ✨ Fixed formatting issues

  kunkoala

  committed
  5e23173

  Copy full SHA for 5e23173

• ✨ added license

  kunkoala

  committed
  3ab1df5

  Copy full SHA for 3ab1df5

• 🔧 🔨 refactored district data type and use it on different files

  kunkoala

  committed
  5bc28f9

  Copy full SHA for 5bc28f9

• 🔧 edited some functions for horizontal threshold slice in UserPreferenceSlice

  kunkoala

  committed
  17084aa

  Copy full SHA for 17084aa

• 🎉 🔧 🔨 refactored some file structures, added line chart settings menu to the bottom left that is customizable and able to add new menus such as filters, added a horizontal line settings menu that i…

  Show description for 8e50ab8
  kunkoala

  committed
  8e50ab8

  Copy full SHA for 8e50ab8

• 🔧 ✨ added some error handlings and for adding a new threshold and some refactors

  kunkoala

  committed
  d163ad7

  Copy full SHA for d163ad7

• 🔧 Set horizontal thresholds in store

  kunkoala

  committed
  6537912

  Copy full SHA for 6537912

• ✨ add license to type

  kunkoala

  committed
  15a32b5

  Copy full SHA for 15a32b5

• 🔧 refactor some state names to adhere to naming conventions

  kunkoala

  committed
  e74e581

  Copy full SHA for e74e581

• 🔧 🎉 added a useEffect to change the selected map area when the district store changes

  kunkoala

  committed
  da06a9c

  Copy full SHA for da06a9c

• 🎉 🔨 refactor HorizontalThresholdList into HorizontalThresholdList- and Item, now highlights selected area based on the current selected district and compartment

  kunkoala

  committed
  f7e93ed

  Copy full SHA for f7e93ed

• 🔧 added some conditionals to prevent unnecessary re-renders

  kunkoala

  committed
  2aa1273

  Copy full SHA for 2aa1273

• 🔧 🔨 🎉 ❇️ distinct styling for selected threshold and logic, refactor threshold input component and code style

  kunkoala

  committed
  0e60de3

  Copy full SHA for 0e60de3

• 🔧 useEffect dependencies

  kunkoala

  committed
  d121a6a

  Copy full SHA for d121a6a

• 🔧 use useRef for selected area and update the compartments to change when the store changes

  kunkoala

  committed
  101a5d7

  Copy full SHA for 101a5d7

• 🔧 🔨 use MUI Table for the threshold list

  kunkoala

  committed
  0d1a074

  Copy full SHA for 0d1a074

• ✔️ add new userPreferenceSlice test to include threshold

  kunkoala

  committed
  a12eccd

  Copy full SHA for a12eccd

• 🔨 ❇️ refactored horizontal threshold components, added test id for testing

  kunkoala

  committed
  20f5cde

  Copy full SHA for 20f5cde

• 🔧 improved UX by disabling clicking other items when user is editing / adding a new threshold, improved styling, added some testid

  kunkoala

  committed
  8baf1bf

  Copy full SHA for 8baf1bf

• ✔️ created tests for HorizontalThreshold components and UserPreferenceSlice

  kunkoala

  committed
  4489b9c

  Copy full SHA for 4489b9c

• 🔧 🪲 fixed import statement case for FilterValue in DataCard.test.tsx

  kunkoala

  committed
  a41b1ea

  Copy full SHA for a41b1ea

• 🔧 ✨ 💚 added missing reuse compliance

  kunkoala

  committed
  3de3463

  Copy full SHA for 3de3463

• 🔧 🪲 small refactor and bug fix

  kunkoala

  committed
  d2fe674

  Copy full SHA for d2fe674

• 🎉 🔧 added localization for settings menu and horizontal threshold

  kunkoala

  committed
  2551923

  Copy full SHA for 2551923

• 💚 fix license

  kunkoala

  committed
  fd43fa2

  Copy full SHA for fd43fa2

• 🎉 🔧 generalized the settings menu as a popover, moved the filterComponents to LineChartSettings

  kunkoala

  committed
  dbe7761

  Copy full SHA for dbe7761

• 🎉 rebase

  kunkoala

  committed
  f48fee6

  Copy full SHA for f48fee6

• 🔧 fixed some locales, fix test for lineChartSettings to use testid

  kunkoala

  committed
  82d597c

  Copy full SHA for 82d597c

• 🔥 delete unused localization for compartments

  kunkoala

  committed
  63da0f7

  Copy full SHA for 63da0f7