feat: Remote interface interoperate distributed computing resources #143
Conversation
|
Commit should be atomic. Please consider rebase to several ones. Also some test cases would be nice. |
|
The prefix |
ajblane
force-pushed
the
remote-interface
branch
from
150b7a5 to
0720ff0
Compare
I saw that some functions have the name with |
|
Check list for merging this pull request:
|
ajblane
force-pushed
the
remote-interface
branch
9 times, most recently
from
7eac396 to
e07bfb1
Compare
| mkdir $(LIBRABBITMQ_PATH)/build | ||
| ifeq ($(UNAME_S),darwin) | ||
| # macOS | ||
| cd $(LIBRABBITMQ_PATH)/build && \ |
There was a problem hiding this comment.
I wonder whether this is really necessary to enter the $(LIBRABBITMQ_PATH)/build directory.
It seems using $(LIBRABBITMQ_PATH) is fine.
There was a problem hiding this comment.
I think that using cmake keeps simple as entering $(LIBRABBITMQ_PATH)/build directory to build and configure RabbitMQ.
There was a problem hiding this comment.
For example, can't it be like:
cmake -DOPENSSL_ROOT_DIR=/usr/local/opt/openssl/ -DCMAKE_INSTALL_PREFIX=./build . && \
cmake --build ./build --target install
There was a problem hiding this comment.
An error occurs as entering $(LIBRABBITMQ_PATH) and using the above command to build as follows:
-- Found POPT: /usr/include
-- Found XMLTO: /usr/bin/xmlto
-- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE)
-- Building rabbitmq as a shared library - yes
-- Building rabbitmq as a static library - yes
-- Configuring done
-- Generating done
-- Build files have been written to: /home/xxxx/Desktop/dcurl/deps/rabbitmq-c
Error: could not load cache
| if (frame.payload.method.id != AMQP_BASIC_DELIVER_METHOD) | ||
| continue; | ||
|
|
||
| #if defined(ENABLE_DEBUG) |
There was a problem hiding this comment.
The ENABLE_DEBUG can be removed since you have already used the ddprintf().
At least ddprintf() should not be placed between the #if defined(ENABLE_DEBUG) ... #endif macro.
| #if defined(ENABLE_DEBUG) | ||
| p = (amqp_basic_properties_t *) frame.payload.properties.decoded; | ||
| if (p->_flags & AMQP_BASIC_CONTENT_TYPE_FLAG) { | ||
| ddprintf(MSG_PREFIX "Content-type: %.*s\n", (int) p->content_type.len, |
There was a problem hiding this comment.
p is defined and used by ddprintf when make BUILD_DEBUG. Therefore, the ENABLE_DEBUG needs to be used.
* make BUILD_REMOTE=1 to build libdcurl.so and remote-worker * make BUILD_REMOTE=1 check with RabbitMQ broker and remote-worker * RPC with exclusive callback queues with TTL property * AMQP connection management for multiple threads * Implement local fallback PoW when remote interface fails Related DLTcollab#137
Resolved #137