Skip to content
This repository has been archived by the owner on Dec 26, 2022. It is now read-only.

feat(mam): Implement ECDH for MAM key exchange #735

Merged
merged 1 commit into from
Dec 30, 2020
Merged

feat(mam): Implement ECDH for MAM key exchange #735

merged 1 commit into from
Dec 30, 2020

Conversation

howjmay
Copy link
Contributor

@howjmay howjmay commented Jul 30, 2020 •
edited
Loading

We will combine ECDH and ECDSA for station to station protocol which can be used for key exchange.
In this PR, only ECDH has been implemented.

For #560

jserv
jserv suggested changes Jul 30, 2020
View reviewed changes
Copy link
Member

@jserv jserv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add copyright notice in each file.

jserv
jserv reviewed Jul 30, 2020
View reviewed changes
crypto/ecdh.c Outdated Show resolved Hide resolved
@howjmay howjmay force-pushed the ecdh branch 2 times, most recently from 0693c54 to 71c3435 Compare July 31, 2020 07:42
@howjmay howjmay added A-mam Area - MAM C-feature Category - feature labels Jul 31, 2020
@howjmay howjmay force-pushed the ecdh branch 3 times, most recently from a63312d to caab623 Compare July 31, 2020 07:59
@howjmay howjmay marked this pull request as ready for review July 31, 2020 08:16
@howjmay howjmay requested review from marktwtn and jserv July 31, 2020 08:22
@howjmay howjmay force-pushed the ecdh branch 3 times, most recently from d226003 to 94840cd Compare July 31, 2020 13:55
jserv
jserv reviewed Aug 19, 2020
View reviewed changes
common/ta_errors.c Outdated Show resolved Hide resolved
jserv
jserv reviewed Aug 19, 2020
View reviewed changes
common/ta_errors.h Outdated Show resolved Hide resolved
jserv
jserv reviewed Aug 19, 2020
View reviewed changes
crypto/ecdh.c Outdated Show resolved Hide resolved
jserv
jserv reviewed Aug 19, 2020
View reviewed changes
common/ta_errors.c Outdated Show resolved Hide resolved
jserv
jserv reviewed Aug 19, 2020
View reviewed changes
common/ta_errors.c Outdated Show resolved Hide resolved
jserv
jserv reviewed Aug 20, 2020
View reviewed changes
common/ta_errors.c Outdated Show resolved Hide resolved
jserv
jserv reviewed Aug 20, 2020
View reviewed changes
crypto/ecdh.c Outdated Show resolved Hide resolved
jserv
jserv reviewed Aug 20, 2020
View reviewed changes
crypto/ecdh.h Outdated Show resolved Hide resolved
jserv
jserv reviewed Aug 20, 2020
View reviewed changes
crypto/ecdh.h Outdated Show resolved Hide resolved
jserv
jserv reviewed Aug 20, 2020
View reviewed changes
tests/unit-test/test_ecdh.c Outdated Show resolved Hide resolved
@howjmay howjmay requested a review from jserv September 22, 2020 06:22
@jserv
Copy link
Member

jserv commented Oct 5, 2020

Ready to merge?

@splasky splasky force-pushed the ecdh branch 3 times, most recently from 32e9dc0 to fa95078 Compare December 30, 2020 07:32
@splasky splasky merged commit a9e0b09 into DLTcollab:develop Dec 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marktwtn marktwtn Awaiting requested review from marktwtn

@jserv jserv Awaiting requested review from jserv

Assignees
No one assigned
Labels
A-mam Area - MAM C-feature Category - feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@howjmay @jserv @splasky