Fix for the formatting issues with bullet points for exported docx plans #2268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xsrust
approved these changes
Nov 1, 2019
|
@johnpinto1 please pin the version of the gem in the the Gemfile |
when viewed in an old Word editor. The fix follows the solution suggested in the HtmlToWord bug "List item bullets corrupted in Microsoft Word" karnov/htmltoword#73 suggested by David Verhasselt @dv. Changes: - Firstly, removed earlier attempted fix in commit 5ef7e05 (Fix for format issues for bullet points in Plan docx exports). - Made a copy of Htmltoword (1.1.0) xslt stylesheets functions.xslt and numbering.xslt and made changes suggested by karnov/htmltoword#73 - Prepended the Htmltoword library XSLTHelper method xslt_path() in config/initializers/htmlto_word_xslt_helper.rb. This method ensures the Htmltoword library picks up the changed numbering.xslt template instead of the library's version. - pinned version of htmltoword to 1.1.0 Fix for issue #2147.
briri
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
Looks good @johnpinto1. Thanks for pegging the htmltoword gem version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when viewed in an old Word editor.
The fix follows the solution suggested in the HtmlToWord bug "List item
bullets corrupted in Microsoft Word"
karnov/htmltoword#73 suggested by David
Verhasselt @dv.
Changes:
5ef7e05 (Fix for format issues for
bullet points in Plan docx exports).
and numbering.xslt and made changes suggested by List item bullets corrupted in Microsoft Word karnov/htmltoword#73
config/initializers/htmlto_word_xslt_helper.rb. This method ensures
the Htmltoword library picks up the changed numbering.xslt template instead of
the library's version.
Fix for issue #2147.
@dsisu Tested the downloaded docx in an old Word editor.
Test_Bullets_2 (8).docx