Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added instructions to create a RootCA and a client certificate and bind it to IIS web site #726

Closed
wants to merge 7 commits into from

Conversation

MaiklT
Copy link

@MaiklT MaiklT commented Aug 28, 2024

Closes #680

MaiklT added 6 commits August 27, 2024 14:27
Added definitionName to the moduleDefinition section. This can be different from the friendly name.
Copy link
Collaborator

@david-poindexter david-poindexter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaiklT perhaps this belongs in a blog post instead of documentation? This is quite opinionated (not that it is wrong) in general and there are many ways to go about doing this based on personal preference. What do you think?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe this file belongs in this PR.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right - something got mixed up.

Copy link
Author

@MaiklT MaiklT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this pull request, thanks!

@valadas valadas closed this Oct 2, 2024
@MaiklT MaiklT deleted the https-680 branch October 30, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback for Enable and Set Up IIS
3 participants