Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for targeting of the root domain when creating managed dns records #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jimrubenstein
Copy link

Implements proposed solution found here #2

@eperry
Copy link

eperry commented Sep 27, 2020

I have tested this patch and from that test, this seems to a good solution, and the @ sign is an industry standard. I also tested this with the terraform module for DME and it worked.

I would like to see this solution merged as well

@nkatarmal-crest
Copy link
Contributor

We can fix it without introducing a new placeholder for empty value. I will look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants