Hotfix/20250401 1358 issue3975 fix notifications

[richard-jones]

• Issue: [enter link to issue here]

---

Title <- provide a title for the PR

briefly describe the PR here

This PR...

• has scripts to run
• has migrations to run
• adds new infrastructure
• changes the CI pipeline
• affects the public site
• affects the editorial area
• affects the publisher area
• affects the monitoring

Developer Checklist

Developers should review and confirm each of these items before requesting review

• Code meets acceptance criteria from issue
• Unit tests are written and all pass
• User Test Scripts (if required) are written and have been run through
• Project's coding standards are met
  • No deprecated methods are used
  • No magic strings/numbers - all strings are in constants or messages files
  • ES queries are wrapped in a Query object rather than inlined in the code
  • Where possible our common library functions have been used (e.g. dates manipulated via dates)
  • Cleaned up commented out code, etc
  • Urls are constructed with url_for not hard-coded
• Code documentation and related non-code documentation has all been updated
  • Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• Migation has been created and tested
• There is a recent merge from develop

Reviewer Checklist

Reviewers should review and confirm each of these items before approval
If there are multiple reviewers, this section should be duplicated for each reviewer

• Code meets acceptance criteria from issue
• Unit tests are written and all pass
• User Test Scripts (if required) are written and have been run through
• Project's coding standards are met
  • No deprecated methods are used
  • No magic strings/numbers - all strings are in constants or messages files
  • ES queries are wrapped in a Query object rather than inlined in the code
  • Where possible our common library functions have been used (e.g. dates manipulated via dates)
  • Cleaned up commented out code, etc
  • Urls are constructed with url_for not hard-coded
• Code documentation and related non-code documentation has all been updated
  • Core model documentation has been added to if needed: https://docs.google.com/spreadsheets/d/1lun2S9vwGbyfy3WjIjgXBm05D-3wWDZ4bp8xiIYfImM/edit
  • Events and consumers documentation has been added if needed: https://docs.google.com/spreadsheets/d/1oIeG5vg-blm2MZCE-7YhwulUlSz6TOUeY8jAftdP9JE/edit
• Migation has been created and tested
• There is a recent merge from develop

Testing

You can run the new testdrive with

http://localhost:5004/testdrive/notifications

and verify that the notifications are created correctly for each user type.

Deployment

No deployment considerations

[Copilot]

Copilot reviewed 32 out of 32 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (4)

portality/events/consumers/application_publisher_revision_notify.py:31

• Explicitly returning None improves clarity; please verify that downstream code correctly handles this None value as expected.

return None

portality/events/consumers/application_publisher_revision_notify.py:51

• Returning the notification object after sending the notification may affect caller expectations; confirm that consumers of this function are prepared to handle the returned object.

return notification

doajtest/fixtures/v2/applications.py:26

• Removing 'current_journal' from the application source might impact tests or functionality that expect this key; verify that this change is intentional and safe.

del result["admin"]["current_journal"]

portality/events/consumers/application_editor_acceptreject_notify.py:25

• Introducing a check for application_type changes the notification logic; please ensure that this new condition aligns with the intended business rules.

if application.application_type != constants.APPLICATION_TYPE_NEW_APPLICATION:

[Steven-Eardley]

This looks good, although I'd have preferred a bit more docs for lib.dicts