Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UNDERC depth data and crosswalk, Isle Royale hypso data and crosswalk #327

Merged
merged 13 commits into from
Apr 15, 2022

Conversation

jordansread
Copy link

I put both issue #261 and #176 in here. #261 is only partially resolved because the temperature data are not yet in the pipeline and the light attenuation data (additional processing of "PAR" profiles in the same dataset as the temperature) are required to gain more lakes.

Despite the UNDERC dataset having 100+ lakes, we only gained one from that depth dataset. The others were either already in the pipeline or not in but still missing Kw/secchi data so not considered a "GLM" lake at this point, which is our lowest threshold for modeling.

The Isle Royale (ISRO) dataset added more, since the pipeline seemingly already had temperature and secchi data for these sites (likely from WQP) and so adding hypsography resulted in ten new GLM lakes and eight new PGDL lakes. Also, since these lakes seem to be highly observed, it is worth noting that I only added the low hanging fruit contour lakes which could be easily turned into hypso. I didn't try to handle multilines so I'm not sure if issues like #167 will exist or if these could be cast into polygons without issue. We probably want to spin off another lower priority issue for the rest of the ISRO lakes.

image

@jordansread
Copy link
Author

Oh yeah, a zoom in on the island
image

for #176

@lindsayplatt lindsayplatt self-requested a review April 12, 2022 20:11
Copy link
Contributor

@lindsayplatt lindsayplatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran scmake('8_viz/out/lakes_summary_fig.html.ind') and it did what I expected up until it started to build 7_drivers_munge/out/7_drivers_munge_tasks.ind, so I stopped it.

1_crosswalk_fetch.yml Show resolved Hide resolved
1_crosswalk_fetch/src/fetch_crosswalk.R Outdated Show resolved Hide resolved
1_crosswalk_fetch/src/fetch_crosswalk.R Show resolved Hide resolved
@@ -1,153 +1,154 @@
7a_temp_coop_munge/tmp/1945_2020_All_MNDNR_MPCA_Temp_DO_Profiles.rds.ind: ab2f36cec6a8803f1aa28f0ebe4d1d47
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why all of these hashes changed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is related to this scipiper issue but I haven't dug into it. Agreed that it is annoying, whatever is causing it.

@lindsayplatt lindsayplatt merged commit 256ee2e into DOI-USGS:main Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants