Lake Package improvements; some fixes for recent numpy and pandas changes #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add automatic writing of lake polygon and lake cell connection shapefiles * Add name_column arg to shapefile input (which adds names to lake auxiliary tables) * Allow PRISM input to be specified for all lakes (via single filename instead of dictionary) * Allow specification of lakes_shapefile: without include_ids: item * Move output tables to tables/ folder
… be specified for evaluating np.any along the 0th axis; the returned scalar 'True' was resulting in no head observation input getting written
…s can be set to fail if invalid arguments are passed, with the valid args printed
…me and end_datetime cols to datetime64[ns] so that pd.concat doesn't fail with heterogenous dtypes
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## develop #72 +/- ##
===========================================
- Coverage 89.14% 89.07% -0.08%
===========================================
Files 64 64
Lines 12305 12345 +40
===========================================
+ Hits 10969 10996 +27
- Misses 1336 1349 +13
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.