Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor fixes for mf6 model setup #80

Merged
merged 1 commit into from
Apr 3, 2024
Merged

minor fixes for mf6 model setup #80

merged 1 commit into from
Apr 3, 2024

Conversation

apryet
Copy link
Contributor

@apryet apryet commented Apr 3, 2024

Missing **kwargs argument in setup_tdis() caused crash when called from package_setup.

Boolean var from_model not initialized when data taken from a file.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.31%. Comparing base (4bfd847) to head (45bcf02).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #80   +/-   ##
========================================
  Coverage    89.31%   89.31%           
========================================
  Files           64       64           
  Lines        12545    12546    +1     
========================================
+ Hits         11205    11206    +1     
  Misses        1340     1340           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleaf
Copy link
Collaborator

aleaf commented Apr 3, 2024

Thanks @apryet !

@aleaf aleaf merged commit 5c55095 into DOI-USGS:develop Apr 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants