suggested fixes #82
Merged
suggested fixes #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad to proj issues. Bypassed when source raster is loaded with rasterio and affine transform specified
aleaf
force-pushed
the
ap-fix-branch
branch
from
4175efe to
ee0a7e5
Compare
…its to the model top if the lake package is being built, and a lake bathymetry raster was supplied (to be subtracted from the initial model top, which presumably represents a typical lake surface elevation, so that the model top is set at the lake bottom.
aleaf
force-pushed
the
ap-fix-branch
branch
from
ee0a7e5 to
cc70d27
Compare
…ray, since top shouldn't be modified; refactor(sourcedata.setup_array): move resetting of model top to branch where the top modified by supplied lake bathymetry (since this should be the only situation where this is needed)
aleaf
force-pushed
the
ap-fix-branch
branch
from
f1a8683 to
0be02d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Andy
Here are two suggested fixes :
fcddf29 sets the raster loading method to avoid issue in projection (circumvents bug in rasterstats)
09b2cc0 removes unnecessary processing of array data for generic (non high k lakes)
Feel free to take them into consideration !
Alex