Fix lgr sfr mover #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions; tests(conftest.py): convert path fixtures to pathlib objects
…urce_data=True, don't copy idomain from parent (which will result in all inactive cells in the inset model).
…hin the 'lgr': 'cfg' sub-block (when LGR inset configuration is supplied in the same file; this is mostly done in a test context).
…changes and a threshold distance to determine SFR Package connections between a parent and inset/child LGR model. This fixes previous issue where SFR streams meandering in and out of the inset model were not getting connected to the parent model (due to SFRmaker connecting the segments within either model).
aleaf
force-pushed
the
fix_lgr_sfr_mover
branch
from
8682276 to
7d52c3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.