Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --privileged instead of --cap-add=sys_admin due to build error #163

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Use --privileged instead of --cap-add=sys_admin due to build error #163

merged 1 commit into from
Dec 12, 2023

Conversation

agcom
Copy link
Contributor

@agcom agcom commented Dec 11, 2023

Closes #158.

@agcom
Use --privileged instead of --cap-add=sys_admin due to build error
8ea7e89 
Encountring the following errors with --cap-add=sys_admin inside the dj_make_chroot script; one inside the debootstrap, and the other somewhere inside the script itself:

...
W: Failure trying to run: chroot "/chroot/domjudge" mount -t proc proc /proc
W: See /chroot/domjudge/debootstrap/debootstrap.log for details
...
mount: /chroot/domjudge/proc: cannot mount proc read-only.
       dmesg(1) may have more information after failed mount system call.
...

The /chroot/domjudge/debootstrap/debootstrap.log does not exist nor the dmesg to investigate further (naive approach OFC).
nickygerritsen
nickygerritsen approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@nickygerritsen nickygerritsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine reverting this. If others agree we can merge it.

@agcom
Copy link
Contributor Author

agcom commented Dec 11, 2023

I wish I had the time to investigate further into this (propagate CAP_SYS_ADMIN to needy commands; how? IDK). At least the Docker packaging works after this PR.

@agcom agcom marked this pull request as ready for review December 11, 2023 12:25
@vmcj vmcj merged commit c6b7e9d into DOMjudge:main Dec 12, 2023
3 of 4 checks passed
@agcom agcom deleted the privileged-capsysadmin branch December 16, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickygerritsen nickygerritsen nickygerritsen approved these changes

@vmcj vmcj vmcj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docker/build.sh fails with "/chroot/domjudge/proc: cannot mount proc read-only"
3 participants
@agcom @nickygerritsen @vmcj